From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "Benoît Monin" <benoit.monin@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency
Date: Fri, 14 Nov 2025 16:52:54 +0100 [thread overview]
Message-ID: <87seegr4q1.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <aRH4osz_OFxx8QZc@alpha.franken.de>
Thomas Bogendoerfer <tsbogend@alpha.franken.de> writes:
> On Mon, Nov 10, 2025 at 03:05:23PM +0100, Gregory CLEMENT wrote:
>> Hello Thomas,
>>
>> > With MIPS, it is possible to have SMP enabled without HOTPLUG_CPU
>> > selected. However, in kernel/cpu.c, some code that uses
>> > HOTPLUG_PARALLEL also requires HOTPLUG_CPU to be selected. Therefore,
>> > we should fix the HOTPLUG_PARALLEL dependency to depend on
>> > HOTPLUG_CPU, not just SMP.
>> >
>> > Reported-by: kernel test robot <lkp@intel.com>
>> > Closes: https://lore.kernel.org/oe-kbuild-all/202510270120.21wA1aX1-lkp@intel.com/
>> > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>>
>> Do you have any comments about this fix?
>
> all good from my side, does it need to go via mips-fixes ?
This fixes a build failure that occurs only in unusual kernel
configurations, so from my point of view, it is not critical.
Gregory
>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea. [ RFC1925, 2.3 ]
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-11-14 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251027-mips_paralell_hotplug-v1-1-01b6cd13ee85@bootlin.com>
2025-11-10 14:05 ` [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency Gregory CLEMENT
2025-11-10 14:37 ` Thomas Bogendoerfer
2025-11-14 15:52 ` Gregory CLEMENT [this message]
2025-10-27 16:15 Gregory CLEMENT
2025-12-01 9:41 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seegr4q1.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=benoit.monin@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.