All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Johan Hovold <johan@kernel.org>
Cc: linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] irqchip/qcom-irq-combiner: Rename driver structure
Date: Fri, 17 Oct 2025 15:16:19 +0200	[thread overview]
Message-ID: <87sefhzn18.ffs@tglx> (raw)
In-Reply-To: <20251017055226.7525-1-johan@kernel.org>

On Fri, Oct 17 2025 at 07:52, Johan Hovold wrote:
> The "_probe" suffix of the driver structure name prevents modpost from
> warning about section mismatches so replace it to catch any future
> issues like the recently fixed probe function being incorrectly marked
> as __init.

I take this grudgingly, but not without pointing out again that this is
just a horrible hack. Why can't this stuff be properly annotated and
recorded in a throwaway section so that modpost can act on reliable data
instead of using string matching on arbitrary function names?

Thanks,

        tglx

  reply	other threads:[~2025-10-17 13:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17  5:52 [PATCH] irqchip/qcom-irq-combiner: Rename driver structure Johan Hovold
2025-10-17 13:16 ` Thomas Gleixner [this message]
2025-10-20  9:18   ` Johan Hovold
2025-10-17 13:36 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sefhzn18.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.