From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Kuniyuki Iwashima <kuniyu@google.com>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH v2 net-next 3/6] net/sched: act_mirred: add loop detection
Date: Wed, 15 Oct 2025 10:17:32 +0200 [thread overview]
Message-ID: <87sefkfujn.fsf@toke.dk> (raw)
In-Reply-To: <20251014171907.3554413-4-edumazet@google.com>
Eric Dumazet <edumazet@google.com> writes:
> Commit 0f022d32c3ec ("net/sched: Fix mirred deadlock on device recursion")
> added code in the fast path, even when act_mirred is not used.
>
> Prepare its revert by implementing loop detection in act_mirred.
>
> Adds an array of device pointers in struct netdev_xmit.
>
> tcf_mirred_is_act_redirect() can detect if the array
> already contains the target device.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2025-10-15 8:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 17:19 [PATCH v2 net-next 0/6] net: optimize TX throughput and efficiency Eric Dumazet
2025-10-14 17:19 ` [PATCH v2 net-next 1/6] selftests/net: packetdrill: unflake tcp_user_timeout_user-timeout-probe.pkt Eric Dumazet
2025-10-15 5:54 ` Kuniyuki Iwashima
2025-10-14 17:19 ` [PATCH v2 net-next 2/6] net: add add indirect call wrapper in skb_release_head_state() Eric Dumazet
2025-10-15 3:57 ` Kuniyuki Iwashima
2025-10-15 8:17 ` Toke Høiland-Jørgensen
2025-10-15 12:02 ` Alexander Lobakin
2025-10-15 12:16 ` Eric Dumazet
2025-10-15 12:30 ` Alexander Lobakin
2025-10-15 12:46 ` Eric Dumazet
2025-10-15 12:49 ` Eric Dumazet
2025-10-15 12:54 ` Alexander Lobakin
2025-10-15 13:01 ` Eric Dumazet
2025-10-15 13:08 ` Alexander Lobakin
2025-10-15 13:11 ` Eric Dumazet
2025-10-20 7:01 ` Jason Xing
2025-10-20 7:41 ` Eric Dumazet
2025-10-20 9:14 ` Jason Xing
2025-10-14 17:19 ` [PATCH v2 net-next 3/6] net/sched: act_mirred: add loop detection Eric Dumazet
2025-10-15 5:24 ` Kuniyuki Iwashima
2025-10-15 8:17 ` Toke Høiland-Jørgensen [this message]
2025-10-14 17:19 ` [PATCH v2 net-next 4/6] Revert "net/sched: Fix mirred deadlock on device recursion" Eric Dumazet
2025-10-15 5:26 ` Kuniyuki Iwashima
2025-10-15 8:17 ` Toke Høiland-Jørgensen
2025-10-16 12:03 ` Victor Nogueira
2025-10-14 17:19 ` [PATCH v2 net-next 5/6] net: sched: claim one cache line in Qdisc Eric Dumazet
2025-10-15 5:42 ` Kuniyuki Iwashima
2025-10-15 8:17 ` Toke Høiland-Jørgensen
2025-10-14 17:19 ` [PATCH v2 net-next 6/6] net: dev_queue_xmit() llist adoption Eric Dumazet
2025-10-15 6:20 ` Kuniyuki Iwashima
2025-10-15 22:00 ` [PATCH v2 net-next 0/6] net: optimize TX throughput and efficiency Jamal Hadi Salim
2025-10-15 22:11 ` Eric Dumazet
2025-10-16 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sefkfujn.fsf@toke.dk \
--to=toke@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.