From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19871CAC583 for ; Tue, 9 Sep 2025 11:52:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvwsc-0004fi-Vi; Tue, 09 Sep 2025 07:51:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvwsY-0004aE-3j for qemu-devel@nongnu.org; Tue, 09 Sep 2025 07:51:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvwsR-0001Xr-MM for qemu-devel@nongnu.org; Tue, 09 Sep 2025 07:51:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757418664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CnFggHphPChmFBWHNvv/XbeLCaLk3JFF87BYaY05Elc=; b=Rec8UCGhzTL+XhU4oMQI/VSeTaYm9oCDLxuQMYZFcvfJpM521N5fsr+i9foaKaWjBCijGk NFni0OJBUUw++MkvG6MTQ/0n/1Z932PwLFqWyrxlMI/dDDq8A+kPiiTwF3wzz1Zc1nS2iB gXjAY564n55+zYOYw/EituCJTEnlzAY= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-adZvSHHPMyuS3DaPumoh5A-1; Tue, 09 Sep 2025 07:51:01 -0400 X-MC-Unique: adZvSHHPMyuS3DaPumoh5A-1 X-Mimecast-MFC-AGG-ID: adZvSHHPMyuS3DaPumoh5A_1757418660 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 88DBA1800343; Tue, 9 Sep 2025 11:50:59 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0DF161800447; Tue, 9 Sep 2025 11:50:59 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7BB6C21E6A27; Tue, 09 Sep 2025 13:50:56 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, odaki@rsg.ci.i.u-tokyo.ac.jp, marcandre.lureau@redhat.com Subject: Re: [PATCH 08/12] util/oslib-win32: Revert warning on WSAEventSelect() failure In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Tue, 19 Aug 2025 12:24:26 +0100") References: <20250808080823.2638861-1-armbru@redhat.com> <20250808080823.2638861-9-armbru@redhat.com> Date: Tue, 09 Sep 2025 13:50:56 +0200 Message-ID: <87segvyhcv.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Fri, Aug 08, 2025 at 10:08:19AM +0200, Markus Armbruster wrote: >> qemu_socket_select() and its wrapper qemu_socket_unselect() treat a >> NULL @errp as &error_warn. This is wildly inappropriate. A caller >> passing NULL specifies that errors are to be ignored. If warnings are >> wanted, the caller must pass &error_warn. >>=20 >> I'm not familiar with the calling code, so I can't say whether it will >> work after WSAEventSelect() failure. If it doesn't, then this should >> be an error. If it does, then why bother the user with a warning that >> isn't actionable, and likely confusing? >>=20 >> The warning goes back to commit f5fd677ae7cf (win32/socket: introduce >> qemu_socket_select() helper). Before that commit, the error was >> ignored, as indicated by passing a null @errp. Revert to that >> behavior. >>=20 >> Cc: Marc-Andr=C3=A9 Lureau >> Signed-off-by: Markus Armbruster >> --- >> util/oslib-win32.c | 4 ---- >> 1 file changed, 4 deletions(-) >>=20 >> diff --git a/util/oslib-win32.c b/util/oslib-win32.c >> index b7351634ec..136a8fe118 100644 >> --- a/util/oslib-win32.c >> +++ b/util/oslib-win32.c >> @@ -296,10 +296,6 @@ bool qemu_socket_select(int sockfd, WSAEVENT hEvent= Object, >> { >> SOCKET s =3D _get_osfhandle(sockfd); >>=20=20 >> - if (errp =3D=3D NULL) { >> - errp =3D &error_warn; >> - } > > This makes sense, but I'd want the callers to be using warn_report > instead. Ideally some (but not all) of the callers would propagate > the error, but this isn't practical with the QIOChannel create > watch function usage. I'd want to keep Error *errp on this function > though, and have warn_report as a sign to our future selves that > this is still not ideal. The direct callers are qio_channel_create_socket_watch(), aio_set_fd_handler(). Callers via qemu_socket_unselect() are qio_channel_socket_finalize(), qio_channel_socket_close(), qemu_socket_set_block(). All but qio_channel_socket_close() cannot fail. Would you like me to make them pass &error_warn, because warning is less bad than silence there? qio_channel_socket_close() can fail, but it ignores qemu_socket_unselect() failure. What do you want me to do there? >> - >> if (s =3D=3D INVALID_SOCKET) { >> error_setg(errp, "invalid socket fd=3D%d", sockfd); >> return false; >> --=20 >> 2.49.0 >>=20 >>=20 > > With regards, > Daniel