From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: George Chan via B4 Relay <devnull+gchan9527.gmail.com@kernel.org>,
Tom Rini <trini@konsulko.com>,
Casey Connolly <casey.connolly@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sumit Garg <sumit.garg@kernel.org>,
Simon Glass <sjg@chromium.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Lukasz Majewski <lukma@denx.de>, Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io, gchan9527@gmail.com
Subject: Re: [PATCH v2 5/5] usb: gadget: Introduce usb gadget vendor/product default id for ARCH_QCOM
Date: Thu, 12 Jun 2025 09:24:43 +0200 [thread overview]
Message-ID: <87sek5a0ck.fsf@kernel.org> (raw)
In-Reply-To: <20250607-sc7180-android-boot-v2-5-2df5d7f61124@gmail.com>
Hi George,
Thank you for the patch.
On Sat, Jun 07, 2025 at 13:25, George Chan via B4 Relay <devnull+gchan9527.gmail.com@kernel.org> wrote:
> From: George Chan <gchan9527@gmail.com>
>
> Currently vendor/product id are both 0, and that might not as we want.
> Set to some arbitary known value that we can make it work more smoothly.
>
> Signed-off-by: George Chan <gchan9527@gmail.com>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Acked-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Casey, even if this is usb gadget, feel free to pick this up in your
tree.
Thanks,
Mattijs
> ---
> drivers/usb/gadget/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 46a83141481..2a56e360b5f 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -60,6 +60,7 @@ config USB_GADGET_VENDOR_NUM
> default 0x0955 if ARCH_TEGRA
> default 0x1f3a if ARCH_SUNXI
> default 0x2207 if ARCH_ROCKCHIP
> + default 0x18d1 if ARCH_QCOM
> default 0x0
> help
> Vendor ID of the USB device emulated, reported to the host device.
> @@ -86,6 +87,7 @@ config USB_GADGET_PRODUCT_NUM
> default 0x350a if ROCKCHIP_RK3568
> default 0x350b if ROCKCHIP_RK3588
> default 0x350c if ROCKCHIP_RK3528
> + default 0x4ee0 if ARCH_QCOM
> default 0x0
> help
> Product ID of the USB device emulated, reported to the host device.
>
> --
> 2.43.0
prev parent reply other threads:[~2025-06-12 7:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 5:24 [PATCH v2 0/5] A series of patch for enable sc7180 android boot George Chan
2025-06-07 5:24 ` George Chan via B4 Relay
2025-06-07 5:24 ` [PATCH v2 1/5] image-android: Prepend/postpend default bootargs value with given bootcmd George Chan
2025-06-07 5:24 ` George Chan via B4 Relay
2025-06-12 7:19 ` Mattijs Korpershoek
2025-06-07 5:24 ` [PATCH v2 2/5] bootm: Append bootargs value when bootmeth_android provide cmdline George Chan
2025-06-07 5:24 ` George Chan via B4 Relay
2025-06-07 5:24 ` [PATCH v2 3/5] boot: bootmeth_android: Conditionally dependent on abootimg George Chan
2025-06-07 5:24 ` George Chan via B4 Relay
2025-06-12 7:35 ` Mattijs Korpershoek
2025-06-07 5:24 ` [PATCH v2 4/5] iommu: qcom-smmu: Introduce sc7180 compatible string George Chan
2025-06-07 5:24 ` George Chan via B4 Relay
2025-06-07 5:25 ` [PATCH v2 5/5] usb: gadget: Introduce usb gadget vendor/product default id for ARCH_QCOM George Chan
2025-06-07 5:25 ` George Chan via B4 Relay
2025-06-12 7:24 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sek5a0ck.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=casey.connolly@linaro.org \
--cc=devnull+gchan9527.gmail.com@kernel.org \
--cc=gchan9527@gmail.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=sjg@chromium.org \
--cc=sumit.garg@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.