From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v3 2/3] rtc: rzn1: Disable controller before initialization
Date: Mon, 26 May 2025 12:02:05 +0200 [thread overview]
Message-ID: <87sekrzo4i.fsf@bootlin.com> (raw)
In-Reply-To: <20250526095801.35781-7-wsa+renesas@sang-engineering.com> (Wolfram Sang's message of "Mon, 26 May 2025 11:58:03 +0200")
Hello,
On 26/05/2025 at 11:58:03 +02, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> Datasheet says that the controller must be disabled before setting up
> either SUBU or SCMP. This did not matter so far because the driver only
> supported SUBU which was the default, too. It is good practice to follow
> datasheet recommendations, though. It will also be needed because SCMP
> mode will be added in a later patch.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
next prev parent reply other threads:[~2025-05-26 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 9:58 [PATCH v3 0/3] rtc: rzn1: support XTAL clk and SCMP method Wolfram Sang
2025-05-26 9:58 ` [PATCH v3 1/3] dt-bindings: rtc: rzn1: add optional second clock Wolfram Sang
2025-05-26 9:58 ` [PATCH v3 2/3] rtc: rzn1: Disable controller before initialization Wolfram Sang
2025-05-26 10:02 ` Miquel Raynal [this message]
2025-05-26 9:58 ` [PATCH v3 3/3] rtc: rzn1: support input frequencies other than 32768Hz Wolfram Sang
2025-06-01 21:59 ` [PATCH v3 0/3] rtc: rzn1: support XTAL clk and SCMP method Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sekrzo4i.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.