From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9314F29711E for ; Fri, 23 May 2025 17:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748021742; cv=none; b=dKoagPd5IwX5CF3JVV8rFuu8+A/FSRLI47D1fE6Bdi0a4MOYBQ1+jSoSL0tRSCe6GRbj3xrvoI2q+OBU4Iwa10vINAUP8b09+SvXI24XYGLTWjz/qzaw/IjwZKzBLxDcfCll+EiWDRg0VHph2K3mgkiSoAbqTTUYS2daAccbgzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748021742; c=relaxed/simple; bh=OEAitroSdHbcNYJpbUhdpPBxEgAmBgafYQXB0axIBII=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=R7pAdqrAp0Mi1iu+0h1+uhjRzrxJqhqx11c6Kl6/G2s24AmMybGDhBTwQgacDdmMRwPTNcf4fY99z4M+wn1WDTjUFCaMsNkyYykuiHYHXpxxNhi+ao4hMZrJkDXZE98k9D38B6rDlOfPUCVQfHqLZe5q38X71VACbbGbLrTwKsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U9QqcrMa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U9QqcrMa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6C11C4CEE9; Fri, 23 May 2025 17:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748021741; bh=OEAitroSdHbcNYJpbUhdpPBxEgAmBgafYQXB0axIBII=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U9QqcrMaAbtgN0p//8V58QsEwys4EJ20QNpW+oXNeePXmVRfxBGONwLJZZqPAM1Ju W83nRa0WcLmtGz7mSY/gLbh+6SUZTyhnqm8nuprOjQEZdBog9FqWWq6frzz6PxXQR9 cAqO1OINvXIIXS/OJonq6ZppQE4azQZX+fULitkJrmgyaSmA8e0t7guvmpO4LTbp2r JKMqT43MzQu49xfLAAFfQcgGYRltQdLI+Eg2GSySwnHSjmYscQxO0k4JeLH30WrfCL W5B5qiuPgpWOismx9gul/vZdpHprKlzuO//Mp8IlCZwVwdlS4gDANQLB9/N7Jc8TDT zrGw0T8abq/jg== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uIWJ1-0004Gx-QR; Fri, 23 May 2025 18:35:39 +0100 Date: Fri, 23 May 2025 18:35:39 +0100 Message-ID: <87sekvdyc4.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH 0/5] KVM: arm64: Some VGIC-related fixes In-Reply-To: <20250523160810.4049313-1-oliver.upton@linux.dev> References: <20250523160810.4049313-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 23 May 2025 17:08:05 +0100, Oliver Upton wrote: > > Flushing out some patches I had sitting around before vacation: > > - The irqbypass hooks are not resilient to changes in the GSI<->MSI > routing and can sometimes leave behind stale vLPI mappings for the > VM. The fix is to resolve the VGIC IRQ using the host IRQ (which is > stable) and nuking the vLPI mapping upon a routing change. > > - Closing another VGIC race where vCPU creation races with VGIC > creation, leading to in-flight vCPUs entering the kernel w/o private > IRQs allocated. > > Applies to kvmarm-6.16. Apart from the couple of nits I mentioned in my reply to specific patches, this looks good to me. If you can tidy it up some time before -rc1, I'll happily queue it. Thanks, M. -- Jazz isn't dead. It just smells funny.