Re: [PATCH] ALSA: hda/hda_cs_dsp_ctl: Delete hda_cs_dsp_ctl module

[Takashi Iwai <tiwai@suse.de>]

On Thu, 24 Apr 2025 20:12:14 +0200,
Richard Fitzgerald wrote:
> 
> Delete the hda_cs_dsp module and move the one array and one function
> that is used by the cs35l41_hda driver into that driver.
> 
> The cs35l41 and cs35l56 drivers stopped creating ALSA controls to
> wrap firmware controls. The reasons are explained in:
> 
> commit 312c04cee408 ("ALSA: hda: cs35l41: Stop creating ALSA Controls
> for firmware coefficients")
> 
> and
> 
> commit 34e1b1bb7324 ("ALSA: hda: cs35l56: Stop creating ALSA controls
> for firmware coefficients")
> 
> The cs35l56_hda driver now doesn't use hda_cs_dsp_ctl at all. The
> cs35l41_hda driver only uses the small array of firmware names and the
> function to read a control value. All other functions and data in
> hda_cs_dsp_ctl are unused. There is no need to keep a separate module
> for such a small amount of data and code that is only used by one driver,
> so remove the whole module.
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>

Thanks, applied now to for-next branch.


Takashi