All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Elijah Newren <newren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [filter-repo PATCH] Don't crash on multi-line config values
Date: Tue, 28 Jan 2025 19:06:01 +0100	[thread overview]
Message-ID: <87sep2olti.fsf@toke.dk> (raw)
In-Reply-To: <20241214181306.296673-1-toke@toke.dk>

Toke Høiland-Jørgensen <toke@toke.dk> writes:

> The parsing of the output of `git config --list` fails if any of the
> config values contain newlines. Fix this by using the --null parameter
> to `git config`, which is designed for this purpose.
>
> Add a simple test that causes the crash pre-patch.

Hi Elijah

Any chance you could merge this? Seems a couple of others found this bug
as well, there are two open PRs on github with alternative fixes for the
same issue...

-Toke

  reply	other threads:[~2025-01-28 18:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-14 18:13 [filter-repo PATCH] Don't crash on multi-line config values Toke Høiland-Jørgensen
2025-01-28 18:06 ` Toke Høiland-Jørgensen [this message]
2025-01-28 18:30 ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sep2olti.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.