From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org,
Dmitry Antipov <dmantipov@yandex.ru>
Subject: Re: [PATCH] wifi: ath9k: adjust ath9k_rx_prepare() and simplify ath9k_rx_tasklet()
Date: Mon, 20 Jan 2025 10:48:17 +0100 [thread overview]
Message-ID: <87sepdn7dq.fsf@toke.dk> (raw)
In-Reply-To: <20250117084823.1193083-1-dmantipov@yandex.ru>
Dmitry Antipov <dmantipov@yandex.ru> writes:
> Adjust 'ath9k_rx_prepare()' to fill skb control buffer directly rather
> than using temporary 'struct ieee80211_rx_status' in 'ath9k_rx_tasklet()',
> thus making both temporary and 'memcpy()' redundant. Compile tested
> only.
Hmm, so the existing code follows the "perform checks, then write data"
pattern, which is generally good practice. I don't think saving a
48-byte memcpy() is worth it to deviate from this pattern. Certainly not
without testing :)
-Toke
prev parent reply other threads:[~2025-01-20 9:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 8:48 [PATCH] wifi: ath9k: adjust ath9k_rx_prepare() and simplify ath9k_rx_tasklet() Dmitry Antipov
2025-01-20 9:48 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sepdn7dq.fsf@toke.dk \
--to=toke@toke.dk \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.