From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: "Peter Xu" <peterx@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v3 03/17] tests/migration: Disambiguate guestperf vs. a-b
Date: Fri, 29 Nov 2024 10:19:36 -0300 [thread overview]
Message-ID: <87serajhxz.fsf@suse.de> (raw)
In-Reply-To: <20241127182901.529-4-farosas@suse.de>
Fabiano Rosas <farosas@suse.de> writes:
> The current build structure for migration tests is confusing. There is
> the tests/migration directory, which contains two different guest code
> implementations, one for the qtests (a-b-{bootblock|kernel}.S) and
> another for the guestperf script (stress.c). One uses a Makefile,
> while the other uses meson.
>
> The next patches will add a new qtests/migration/ directory to hold
> qtest code which will make the situation even more confusing.
>
> Move the guest code used by qtests into a new qtests/migration/
> directory and rename the old one to tests/migration-stress.
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Please squash this in:
-->8--
From 9f8a693e31be198e1e052d86be99ffaaa0a3e8a8 Mon Sep 17 00:00:00 2001
From: Fabiano Rosas <farosas@suse.de>
Date: Fri, 29 Nov 2024 10:05:21 -0300
Subject: [PATCH] fixup! tests/migration: Disambiguate guestperf vs. a-b
---
tests/migration-stress/guestperf/shell.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/migration-stress/guestperf/shell.py b/tests/migration-stress/guestperf/shell.py
index c85d89efec..046afeb84e 100644
--- a/tests/migration-stress/guestperf/shell.py
+++ b/tests/migration-stress/guestperf/shell.py
@@ -46,7 +46,8 @@ def __init__(self):
parser.add_argument("--binary", dest="binary", default="/usr/bin/qemu-system-x86_64")
parser.add_argument("--dst-host", dest="dst_host", default="localhost")
parser.add_argument("--kernel", dest="kernel", default="/boot/vmlinuz-%s" % platform.release())
- parser.add_argument("--initrd", dest="initrd", default="tests/migration/initrd-stress.img")
+ parser.add_argument("--initrd", dest="initrd",
+ default="tests/migration-stress/initrd-stress.img")
parser.add_argument("--transport", dest="transport", default="unix")
--
2.35.3
next prev parent reply other threads:[~2024-11-29 13:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 18:28 [PATCH v3 00/17] tests/qtest: migration-test refactoring Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 01/17] tests/qtest/migration: Standardize hook names Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 02/17] tests/qtest/migration: Stop calling everything "test" Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 03/17] tests/migration: Disambiguate guestperf vs. a-b Fabiano Rosas
2024-11-29 13:19 ` Fabiano Rosas [this message]
2024-12-02 19:50 ` Peter Xu
2024-11-27 18:28 ` [PATCH v3 04/17] tests/qtest/migration: Move bootfile code to its own file Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 05/17] tests/qtest/migration: Move qmp helpers to a separate file Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 06/17] tests/qtest/migration: Rename migration-helpers.c Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 07/17] tests/qtest/migration: Move ufd_version_check to utils Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 08/17] tests/qtest/migration: Move kvm_dirty_ring_supported " Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 09/17] tests/qtest/migration: Isolate test initialization Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 10/17] tests/qtest/migration: Move common test code Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 11/17] tests/qtest/migration: Split TLS tests from migration-test.c Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 12/17] tests/qtest/migration: Split compression " Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 13/17] tests/qtest/migration: Split postcopy tests Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 14/17] tests/qtest/migration: Split file tests Fabiano Rosas
2024-11-27 18:28 ` [PATCH v3 15/17] tests/qtest/migration: Split precopy tests Fabiano Rosas
2024-11-27 18:29 ` [PATCH v3 16/17] tests/qtest/migration: Split CPR tests Fabiano Rosas
2024-11-27 18:29 ` [PATCH v3 17/17] tests/qtest/migration: Split validation tests + misc Fabiano Rosas
2024-12-10 15:06 ` [PATCH v3 00/17] tests/qtest: migration-test refactoring Fabiano Rosas
2024-12-12 12:48 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87serajhxz.fsf@suse.de \
--to=farosas@suse.de \
--cc=berrange@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.