From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA3DFCF6497 for ; Mon, 30 Sep 2024 09:43:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BEE001939; Mon, 30 Sep 2024 11:42:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BEE001939 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1727689388; bh=uJ8/vpmmGhvXBt7yG9xTuuhyrPbqpKEK19L8FPukiGo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=PbkstHe+DYvudPG2Run2FjeCORsAQJFSX23hC4XUPbB4jmun4vL5azXIae9y5xNB2 63gmuRVy3SbOAg652zW89MGOjin8eIBnJF/vm3tY7S1p1zcoUHurUQ4LYz616A+DRl PNqsArn4fi/8jujCdZl0Ot1j4p0RC6MkMVJ3itbY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8C5D3F805AE; Mon, 30 Sep 2024 11:42:37 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B87CDF805B5; Mon, 30 Sep 2024 11:42:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 33755F80508; Mon, 30 Sep 2024 11:42:31 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4891EF80007 for ; Mon, 30 Sep 2024 11:42:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4891EF80007 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=auWm6bJ4; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nbby8iVJ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=auWm6bJ4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nbby8iVJ Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2C5101F7F8; Mon, 30 Sep 2024 09:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727689348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G1seGICz3JPahsuG06QLM3DMJzt/DSNB6Y3TDA5CHFs=; b=auWm6bJ4wF32WSCaEmFGKT0oZfjkEaq45u/aNqEVF/smal3iV5c8NnEkNOyIDKLnSdfJ7H XvXZaFRDSK30yKDOoIEum4DaVNt+Nf4pqnYrZEJTHzf+jg3YFo7fawErxYtihfRMs03hlR LgeVUBrniH05WlHJ6VYslRyFDcIT5H4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727689348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G1seGICz3JPahsuG06QLM3DMJzt/DSNB6Y3TDA5CHFs=; b=nbby8iVJp+Lj18crnS5bZtxtPdx0r6FPBfHF4QH6pGz/O+2inkHnxYc1mo9RoGhpdMJAPW WPK3rMPM0W3VsXDA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727689348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G1seGICz3JPahsuG06QLM3DMJzt/DSNB6Y3TDA5CHFs=; b=auWm6bJ4wF32WSCaEmFGKT0oZfjkEaq45u/aNqEVF/smal3iV5c8NnEkNOyIDKLnSdfJ7H XvXZaFRDSK30yKDOoIEum4DaVNt+Nf4pqnYrZEJTHzf+jg3YFo7fawErxYtihfRMs03hlR LgeVUBrniH05WlHJ6VYslRyFDcIT5H4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727689348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G1seGICz3JPahsuG06QLM3DMJzt/DSNB6Y3TDA5CHFs=; b=nbby8iVJp+Lj18crnS5bZtxtPdx0r6FPBfHF4QH6pGz/O+2inkHnxYc1mo9RoGhpdMJAPW WPK3rMPM0W3VsXDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EE1F3136CB; Mon, 30 Sep 2024 09:42:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3MXBOINy+mZrMwAAD6G6ig (envelope-from ); Mon, 30 Sep 2024 09:42:27 +0000 Date: Mon, 30 Sep 2024 11:43:20 +0200 Message-ID: <87sethiiiv.wl-tiwai@suse.de> From: Takashi Iwai To: Oder Chiou Cc: , , , , Subject: Re: [PATCH] ALSA: hda/realtek: Fix the push button function for the ALC257 In-Reply-To: <20240930085731.2871700-1-oder_chiou@realtek.com> References: <20240930085731.2871700-1-oder_chiou@realtek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid] Message-ID-Hash: 6IIFNXKHFPU3SCPWT7YQR3OY36QX3JWX X-Message-ID-Hash: 6IIFNXKHFPU3SCPWT7YQR3OY36QX3JWX X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 30 Sep 2024 10:57:31 +0200, Oder Chiou wrote: > > The patch "Fix noise from speakers on Lenovo IdeaPad 3 15IAU7" caused > that the headset push button cannot work properly in case of ALC257. > This patch reverted it to correct the side effect. If a previous commit caused such a regression, could you point it, too? At best in a form of "Fixes:" tag. thanks, Takashi > > Signed-off-by: Oder Chiou > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index f787ff4182d4..86db1a4ec24c 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -587,6 +587,7 @@ static void alc_shutup_pins(struct hda_codec *codec) > switch (codec->core.vendor_id) { > case 0x10ec0236: > case 0x10ec0256: > + case 0x10ec0257: > case 0x19e58326: > case 0x10ec0283: > case 0x10ec0285: > -- > 2.34.1 >