From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, lvc-project@linuxtesting.org,
Dmitry Antipov <dmantipov@yandex.ru>,
syzbot+b65e0af58423fc8a73aa@syzkaller.appspotmail.com
Subject: Re: [PATCH net v5 1/2] net: sched: fix use-after-free in taprio_change()
Date: Thu, 05 Sep 2024 09:43:49 -0300 [thread overview]
Message-ID: <87seuenud6.fsf@intel.com> (raw)
In-Reply-To: <20240904120842.3426084-1-dmantipov@yandex.ru>
Dmitry Antipov <dmantipov@yandex.ru> writes:
> In 'taprio_change()', 'admin' pointer may become dangling due to sched
> switch / removal caused by 'advance_sched()', and critical section
> protected by 'q->current_entry_lock' is too small to prevent from such
> a scenario (which causes use-after-free detected by KASAN). Fix this
> by prefer 'rcu_replace_pointer()' over 'rcu_assign_pointer()' to update
> 'admin' immediately before an attempt to schedule freeing.
>
> Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
> Reported-by: syzbot+b65e0af58423fc8a73aa@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=b65e0af58423fc8a73aa
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> v5: unchanged since v4 but resend due to series change
> v4: adjust subject to target net tree
> v3: unchanged since v2
> v2: unchanged since v1
> ---
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cheers,
--
Vinicius
next prev parent reply other threads:[~2024-09-05 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 12:08 [PATCH net v5 1/2] net: sched: fix use-after-free in taprio_change() Dmitry Antipov
2024-09-04 12:08 ` [PATCH net v5 2/2] net: sched: use RCU read-side critical section in taprio_dump() Dmitry Antipov
2024-09-05 12:44 ` Vinicius Costa Gomes
2024-09-05 12:43 ` Vinicius Costa Gomes [this message]
2024-09-20 9:05 ` [PATCH net v5 1/2] net: sched: fix use-after-free in taprio_change() Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seuenud6.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=dmantipov@yandex.ru \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+b65e0af58423fc8a73aa@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.