From: Thomas Gleixner <tglx@linutronix.de>
To: kernel test robot <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
Max Ramanouski <max8rr8@gmail.com>,
Alistair Popple <apopple@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Kees Cook <kees@kernel.org>,
linux-mm@kvack.org, oliver.sang@intel.com
Subject: Re: [tip:x86/urgent] [x86/kaslr] dfb3911c36: kernel_BUG_at_arch/x86/mm/physaddr.c
Date: Tue, 20 Aug 2024 16:37:56 +0200 [thread overview]
Message-ID: <87seuzjm4b.ffs@tglx> (raw)
In-Reply-To: <877ccbl840.ffs@tglx>
On Tue, Aug 20 2024 at 13:57, Thomas Gleixner wrote:
> On Tue, Aug 20 2024 at 15:16, kernel test robot wrote:
> /*
> * KASLR trims the maximum possible size of the
> * direct-map. Update the physmem_end boundary.
> + * No rounding required as the region starts
> + * PUD aligned and size is in units of TB.
> */
> if (kaslr_regions[i].end)
> - *kaslr_regions[i].end = __pa(vaddr) - 1;
> + *kaslr_regions[i].end = __pa_nodebug(vaddr - 1);
> +
> + /* Add a minimum padding based on randomization alignment. */
> + vaddr = round_up(vaddr + 1, PUD_SIZE);
Due to the guaranteed PUD alignment of vaddr this round_up() is actually
pointless and just should be
vaddr += PUD_SIZE;
No?
Thanks,
tglx
prev parent reply other threads:[~2024-08-20 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 7:16 [tip:x86/urgent] [x86/kaslr] dfb3911c36: kernel_BUG_at_arch/x86/mm/physaddr.c kernel test robot
2024-08-20 11:57 ` Thomas Gleixner
2024-08-20 14:37 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seuzjm4b.ffs@tglx \
--to=tglx@linutronix.de \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=max8rr8@gmail.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.