Re: [Buildroot] [PATCH v2] package/boost: Boost.Atomic needs atomic intrinsics

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:

 > On 23/12/2022 14:34, Michael Nosthoff via buildroot wrote:
 >> From: Michael <buildroot@heine.tech>
 >> similar to previous problems with nios2 and not-available atomic
 >> ints
 >> the build for Boost.Atomics also fails for ARC Targets which don't
 >> have the ATOMICS_EXT flag set.
 >> according to [0] "Boost.Atomic has a hard requirement of the native
 >> atomic operations on bytes". The same tests mentioned there fail for
 >> ARC.

 >  Based on that comment, the option
 >  BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS was introduced. So
 >  that one should have been used instead.


 >> so introduce a dependency on BR2_ARC_ATOMIC_EXT for BR2_arc.
 >> add depends clause for all packages using boost-atomic/filesystem.
 >> Fixes:
 >> http://autobuild.buildroot.net/results/4ca54a85672d7b9328b1909b457e548c6032a493
 >> [0]
 >> https://github.com/boostorg/atomic/issues/42#issuecomment-734130348
 >> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

 >  I changed the entire patch to this:

 > diff --git a/toolchain/Config.in b/toolchain/Config.in
 > index 1aa17cbfbd..8acdc62fc2 100644
 > --- a/toolchain/Config.in
 > +++ b/toolchain/Config.in
 > @@ -94,6 +94,7 @@ config BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 >         depends on !BR2_ARM_CPU_ARMV5
 >         depends on !BR2_sparc_v8
 >         depends on !BR2_m68k_cf5208
 > +       depends on !(BR2_arc && !BR2_ARC_ATOMIC_EXT)

 >  # GCC uses thunk functions to adjust the 'this' pointer when calling
 >  # C++ member functions in classes derived with multiple inheritance.


 > and applied to master, thanks.

Committed to 2024.02.x and 2024.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot