From: Markus Armbruster <armbru@redhat.com>
To: Josh Junon <junon@oro.sh>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] qmp: Fix higher half vaddrs for [p]memsave
Date: Fri, 02 Aug 2024 15:21:13 +0200 [thread overview]
Message-ID: <87sevn12nq.fsf@pond.sub.org> (raw)
In-Reply-To: <ZqzK/Wja59qAjbCY@DESKTOP-TBGODF1.localdomain> (Josh Junon's message of "Fri, 2 Aug 2024 14:03:09 +0200")
Josh Junon <junon@oro.sh> writes:
> On Fri, Aug 02, 2024 at 01:39:15PM +0200, Markus Armbruster wrote:
[...]
>> I'd go for a much smaller solution: change the QMP commands to unsigned,
>> keep the HMP commands signed, with a silent conversion just like
>> hmp_memory_dump() & friends.
>>
>
> Sounds good to me, thanks for the review!
You're welcome! Looking forward to v2.
prev parent reply other threads:[~2024-08-02 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 13:50 [PATCH] qmp: Fix higher half vaddrs for [p]memsave Josh Junon
2024-08-02 11:39 ` Markus Armbruster
2024-08-02 12:03 ` Josh Junon
2024-08-02 13:21 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sevn12nq.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=junon@oro.sh \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.