From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF649C47422 for ; Mon, 29 Jan 2024 12:14:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUQWn-0008DU-H0; Mon, 29 Jan 2024 07:14:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUQWj-0008Cn-H7 for qemu-devel@nongnu.org; Mon, 29 Jan 2024 07:14:13 -0500 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUQWh-0003Bj-MX for qemu-devel@nongnu.org; Mon, 29 Jan 2024 07:14:13 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3861121D01; Mon, 29 Jan 2024 12:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706530446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P8v7BLnX7/811ENBjd2bKHIecRsfG65Bpt8dtTHL/zY=; b=jyYEFyO+l7KEtaXeiVtOQi7iaLc6w296zHRXwSeGPedlWFf0/dcvHswwedSyAwQRB9CH0x tM4QWo+LxmYWw7PypEixWttXtFYZqMS6+SKKO5BxuwaM/yjC41guKegAnMYFAz168Gbb2f Fux9e1Zqa6cZXoi+XEK3OZ8cdUQBguk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706530446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P8v7BLnX7/811ENBjd2bKHIecRsfG65Bpt8dtTHL/zY=; b=Da4qHY4DGSTmgq4ILe00uEz2cYI5XaZHLA5f7id4XPrxF6dEuxScXAIZ0AFfFnoPU6q/ul qlLLASXu8QCe5XCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706530444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P8v7BLnX7/811ENBjd2bKHIecRsfG65Bpt8dtTHL/zY=; b=AtbQTfYJL3FPBhTpHznzsy5vYBz4mE9D/eZf9Smpevg2f4x1nYxYCPzo5r5QqBn1CcdDRc uZTpH/tl5S/HIoQZRhBJ0AWp4J7/JXoDgI8U1L1NGF9POXn+ESshWxC5dJkkKB00Nlom7G 16y8g6YeeWDy3pxOWhNMmLfFnWz3kZM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706530444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P8v7BLnX7/811ENBjd2bKHIecRsfG65Bpt8dtTHL/zY=; b=lgcovkUxXDN0ar67nr59JUcIEXjM6SllRd6SXUSmAHBphlu/rjkSmLPCOJsz6el/ihMqtP pjCI6Wg9WcC777BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B8A6D12FF7; Mon, 29 Jan 2024 12:14:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 75nvH4uWt2WiFgAAD6G6ig (envelope-from ); Mon, 29 Jan 2024 12:14:03 +0000 From: Fabiano Rosas To: Peter Xu Cc: Peter Maydell , qemu-devel@nongnu.org Subject: Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64 In-Reply-To: References: <20240126041725.124562-1-peterx@redhat.com> <20240126041725.124562-7-peterx@redhat.com> <87le8c6u1d.fsf@suse.de> <87il3g6t7b.fsf@suse.de> Date: Mon, 29 Jan 2024 09:14:01 -0300 Message-ID: <87sf2ge3qu.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=AtbQTfYJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lgcovkUx X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; BAYES_HAM(-3.00)[100.00%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[linaro.org:email,suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-0.994]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 3861121D01 Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > On Fri, Jan 26, 2024 at 11:54:32AM -0300, Fabiano Rosas wrote: >> Peter Maydell writes: >> >> > On Fri, 26 Jan 2024 at 14:36, Fabiano Rosas wrote: >> >> >> >> peterx@redhat.com writes: >> >> >> >> > From: Fabiano Rosas >> >> > >> >> > The 'max' cpu is not expected to be stable in terms of features across >> >> > QEMU versions, so it should not be expected to migrate. >> >> > >> >> > While the tests currently all pass with -cpu max, that is only because >> >> > we're not testing across QEMU versions, which is the more common >> >> > use-case for migration. >> >> > >> >> > We've recently introduced compatibility tests that use two different >> >> > QEMU versions and the tests are now failing for aarch64. The next >> >> > patch adds those tests to CI, so we cannot use the 'max' cpu >> >> > anymore. Replace it with the 'neoverse-n1', which has a fixed set of >> >> > features. >> >> > >> >> > Suggested-by: Peter Maydell >> >> > Signed-off-by: Fabiano Rosas >> >> > Link: https://lore.kernel.org/r/20240118164951.30350-2-farosas@suse.de >> >> > Signed-off-by: Peter Xu >> >> > --- >> >> > tests/qtest/migration-test.c | 2 +- >> >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > >> >> > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c >> >> > index 7675519cfa..15713f3666 100644 >> >> > --- a/tests/qtest/migration-test.c >> >> > +++ b/tests/qtest/migration-test.c >> >> > @@ -820,7 +820,7 @@ static int test_migrate_start(QTestState **from, QTestState **to, >> >> > memory_size = "150M"; >> >> > machine_alias = "virt"; >> >> > machine_opts = "gic-version=max"; >> >> > - arch_opts = g_strdup_printf("-cpu max -kernel %s", bootpath); >> >> > + arch_opts = g_strdup_printf("-cpu neoverse-n1 -kernel %s", bootpath); >> >> > start_address = ARM_TEST_MEM_START; >> >> > end_address = ARM_TEST_MEM_END; >> >> > } else { >> >> >> >> This breaks the tests on an arm host with KVM support. We could drop >> >> this patch from the PR, it doesn't affect anything else. >> >> >> >> Or squash in: >> >> >> >> -->8-- >> >> From b8aa5d8a2b33dcc28e4cd4ce2c4f4eacc3a3b845 Mon Sep 17 00:00:00 2001 >> >> From: Fabiano Rosas >> >> Date: Fri, 26 Jan 2024 11:33:15 -0300 >> >> Subject: [PATCH] fixup! tests/qtest/migration: Don't use -cpu max for aarch64 >> >> >> >> Signed-off-by: Fabiano Rosas >> >> --- >> >> tests/qtest/migration-test.c | 4 +++- >> >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> >> >> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c >> >> index 15713f3666..2ba9cab684 100644 >> >> --- a/tests/qtest/migration-test.c >> >> +++ b/tests/qtest/migration-test.c >> >> @@ -820,7 +820,9 @@ static int test_migrate_start(QTestState **from, QTestState **to, >> >> memory_size = "150M"; >> >> machine_alias = "virt"; >> >> machine_opts = "gic-version=max"; >> >> - arch_opts = g_strdup_printf("-cpu neoverse-n1 -kernel %s", bootpath); >> >> + arch_opts = g_strdup_printf("-cpu %s -kernel %s", >> >> + qtest_has_accel("kvm") ? >> >> + "host" : "neoverse-n1", bootpath); >> >> start_address = ARM_TEST_MEM_START; >> >> end_address = ARM_TEST_MEM_END; >> >> } else { >> > >> > If you want to do that then a comment explaining why would be >> > helpful for future readers, I think. >> >> Ok, let's drop this one then, I'll resend. > > I'll drop this one for now then, thanks. > > Just to double check: Fabiano, you meant that "-cpu host" won't hit the > same issue as what "-cpu max" would have for the new "n-1" CI test, right? Well, no. What we need here is a cpu that works with KVM. Currently that's 'host'. If that breaks the n-1 test, then it's a regression. We also need a cpu that works with TCG. Any of them would do. Except max which changes in incompatible ways (that was the original patch's purpose). The issue that occurs to me now is that 'cpu host' will not work with TCG. We might actually need to go poking /dev/kvm for this to work.