All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Clément Villeret" <clement.villeret@gmail.com>
Cc: linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz
Subject: Re: ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA
Date: Thu, 14 Dec 2023 09:49:29 +0100	[thread overview]
Message-ID: <87sf45qicm.wl-tiwai@suse.de> (raw)
In-Reply-To: <446e6c6d-f639-4576-804a-e64e3fa4c463@gmail.com>

On Wed, 13 Dec 2023 20:36:09 +0100,
Clément Villeret wrote:
> 
> 
> Asus ROG Flowx13 (GV302XA) seems require same patch as others asus products
> 
> Signed-off-by: Clément Villeret <clement.villeret@gmail.com>

Now better, but...

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> 
> index 0377912e9264..eb9f617b6273 100644
> 
> --- a/sound/pci/hda/patch_realtek.c
> 
> +++ b/sound/pci/hda/patch_realtek.c
> 
> @@ -9953,6 +9953,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> 
>                       SND_PCI_QUIRK(0x1043, 0x1483, "ASUS GU603V", ALC285_FIXUP_ASUS_HEADSET_MIC),
> 
>                       SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC),
(snip)

The lines above are weirdly formatted with extra line feeds.
Try the following before resubmission:
- Send the patch to yourself, save the mail content
- Apply the mail content via "git am" command
- If this works, it's a correct patch; then submit to the public ML

Also, note that you'd need to put a blank line before Signed-off-by
line.


thanks,

Takashi

       reply	other threads:[~2023-12-14  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <446e6c6d-f639-4576-804a-e64e3fa4c463@gmail.com>
2023-12-14  8:49 ` Takashi Iwai [this message]
2023-12-14 20:36 ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA Clément Villeret
2023-12-15  7:13 ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2023-12-12  7:43 Clément Villeret
2023-12-12  7:46 ` Takashi Iwai
     [not found]   ` <b93febca-6991-4259-9b38-1fee823d02a0@gmail.com>
2023-12-13 16:41     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf45qicm.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=clement.villeret@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.