From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Garg, Nemesa" <nemesa.garg@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [v2 1/2] drm/i915/display: Add support for darskscreen detection
Date: Mon, 30 Oct 2023 12:19:32 +0200 [thread overview]
Message-ID: <87sf5s5s5n.fsf@intel.com> (raw)
In-Reply-To: <DM4PR11MB647706B7EA07B147429A66C4E3A1A@DM4PR11MB6477.namprd11.prod.outlook.com>
On Mon, 30 Oct 2023, "Garg, Nemesa" <nemesa.garg@intel.com> wrote:
> Hi Jani,
>
> Sometimes there is an issue of black screen on the display due to number of errors like invalid input buffers (black), some issue with display programming (no planes enabled, LUTs zeroed) which means some problem with DE. Upon detection following steps can be taken:
> 1.Print in dmesg so user can be aware of this issue upon checking the logs
> 2. Correction steps can be taken and the design is in progress and will come up with follow up patches.
And if the user wants to show a black screen? Does this feature flag an
error?
BR,
Jani.
>
> Thanks and Regards,
> Nemesa
>
>> -----Original Message-----
>> From: Jani Nikula <jani.nikula@linux.intel.com>
>> Sent: Friday, October 27, 2023 4:40 PM
>> To: Garg, Nemesa <nemesa.garg@intel.com>; intel-gfx@lists.freedesktop.org
>> Subject: Re: [Intel-gfx] [v2 1/2] drm/i915/display: Add support for darskscreen
>> detection
>>
>> On Fri, 27 Oct 2023, Nemesa Garg <nemesa.garg@intel.com> wrote:
>> > Darkscreen detection checks if all the pixels of the frame are less
>> > then or equal to the comparision value. The comparision value is set
>> > to 256 i.e black. So upon getting black pixels from the pipe, the dark
>> > screen detect bit is set and an error message will be printed.
>>
>> Okay, this still describes *what* the patch does, but not *why*. Why do we need
>> this? What for?
>>
>> (Please just reply here for starters, instead of resending.)
>>
>>
>> BR,
>> Jani.
>>
>>
>> --
>> Jani Nikula, Intel
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-10-30 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 9:53 [Intel-gfx] [v2 0/2] Enable Darkscreen Feature Nemesa Garg
2023-10-27 9:53 ` [Intel-gfx] [v2 1/2] drm/i915/display: Add support for darskscreen detection Nemesa Garg
2023-10-27 11:10 ` Jani Nikula
2023-10-30 9:37 ` Garg, Nemesa
2023-10-30 10:19 ` Jani Nikula [this message]
2023-10-31 10:18 ` Garg, Nemesa
2023-12-12 6:09 ` Murthy, Arun R
2023-12-12 9:04 ` Jani Nikula
2023-10-27 9:53 ` [Intel-gfx] [v2 2/2] drm/i915/display: Add darkscreen debugfs entry under crtc Nemesa Garg
2023-12-12 6:23 ` Murthy, Arun R
2023-10-27 19:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Darkscreen Feature (rev2) Patchwork
2023-10-27 19:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-27 20:15 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf5s5s5n.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nemesa.garg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.