All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: yonghong.song@linux.dev, bpf@vger.kernel.org,
	Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: Usage of "p" constraint in BPF inline asm
Date: Fri, 11 Aug 2023 16:10:04 +0200	[thread overview]
Message-ID: <87sf8pfz5v.fsf@oracle.com> (raw)
In-Reply-To: <48b24b86e221a9559a13d51df57b72d0da5d0c7f.camel@gmail.com> (Eduard Zingerman's message of "Fri, 11 Aug 2023 15:18:41 +0300")


> On Fri, 2023-08-11 at 14:01 +0200, Jose E. Marchesi wrote:
>> > On Thu, 2023-08-10 at 21:10 +0200, Jose E. Marchesi wrote:
>> > [...]
>> > > Note the same fix would be needed in the inline asm in
>> > > selftests/bpf/progs/iters.c:iter_err_unsafe_asm_loop.
>> > 
>> > Right, sorry. Tested with that change as well, no changes in the
>> > generated object files for clang. Can't grep "p" anywhere else in
>> > selftests.
>> > 
>> > [...]
>> 
>> Thank you.
>> 
>> Ok, so since people seems to agree to the proposed fix, I will prepare a
>> patch for this.  First I will have to set up a kernel BPF development
>> environment... but I guess it is about time for that ;)
>> 
>> Other than running the kernel selftests, is there any other testing you
>> would recommend to a n00b like me, for changes like this (code
>> generation changes)?
>
> What I do is run same kernel selftests as CI:
> - test_verifier
> - test_progs
> - test_progs-no_alu32
> - test_progs-cpuv4
>
> Do you need any help with the environment itself?
> (I can describe my setup if you need that).

That would be useful yes, thank you.

  parent reply	other threads:[~2023-08-11 14:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 10:35 Usage of "p" constraint in BPF inline asm Jose E. Marchesi
2023-08-10 17:26 ` Yonghong Song
2023-08-10 17:39   ` Jose E. Marchesi
2023-08-10 17:45     ` Yonghong Song
2023-08-10 19:01       ` Eduard Zingerman
2023-08-10 19:10         ` Jose E. Marchesi
2023-08-10 19:38           ` Eduard Zingerman
2023-08-11 12:01             ` Jose E. Marchesi
2023-08-11 12:18               ` Eduard Zingerman
2023-08-11 12:27                 ` Eduard Zingerman
2023-08-11 14:10                 ` Jose E. Marchesi [this message]
2023-08-11 16:12                   ` Eduard Zingerman
2023-08-11 17:22                     ` Jose E. Marchesi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf8pfz5v.fsf@oracle.com \
    --to=jose.marchesi@oracle.com \
    --cc=bpf@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.