All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Pink Perfect <pinkperfect2021@gmail.com>,
	amitkarwar@gmail.com, ganapathi017@gmail.com,
	sharvari.harisangam@nxp.com, huxinming820@gmail.com,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] wifi: mwifiex: Fix OOB and integer underflow when rx packets
Date: Thu, 20 Jul 2023 09:55:38 +0300	[thread overview]
Message-ID: <87sf9j3wd1.fsf@kernel.org> (raw)
In-Reply-To: <20230713105644.49444826@kernel.org> (Jakub Kicinski's message of "Thu, 13 Jul 2023 10:56:44 -0700")

Jakub Kicinski <kuba@kernel.org> writes:

> On Thu, 13 Jul 2023 10:44:56 +0800 Pink Perfect wrote:
>> Sorry, forgot to change the signoff name, after you review this patch I can
>> submit a new one
>
> Do you mean change to "Pink Perfect", is that the name you'd sign
> legal documents with?
>
>> On Thu, Jul 13, 2023 at 10:37 AM pinkperfect <pinkperfect2021@gmail.com>
>> wrote:
>> 
>> > Make sure mwifiex_process_mgmt_packet and its callers
>> > mwifiex_process_sta_rx_packet and mwifiex_process_uap_rx_packet
>> > not out-of-bounds access the skb->data buffer.
>> >
>> > Fixes: 2dbaf751b1de ("mwifiex: report received management frames to
>> > cfg80211")
>> >
>> > Signed-off-by: pinkperfect <pinkperfect2021@gmail.com>
>
> No empty lines between tags, please.
>
> You mentioned reporting the problem to chromeos, since mwifiex
> "maintainters" seem to be AWoL, would someone from their team
> possibly be willing to venture a review tag for the patch?

We have four maintainers for mwifiex and total silence:

MARVELL MWIFIEX WIRELESS DRIVER
M:      Amitkumar Karwar <amitkarwar@gmail.com>
M:      Ganapathi Bhat <ganapathi017@gmail.com>
M:      Sharvari Harisangam <sharvari.harisangam@nxp.com>
M:      Xinming Hu <huxinming820@gmail.com>
L:      linux-wireless@vger.kernel.org
S:      Maintained
F:      drivers/net/wireless/marvell/mwifiex/

I'm very close of marking this driver as orphan unless anyone steps up.
This is not how to maintain a driver.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-07-20  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  2:37 [PATCH v3] wifi: mwifiex: Fix OOB and integer underflow when rx packets pinkperfect
     [not found] ` <CAKNAPeOvG1MVD0y5xuZpN8mSEzvrzcvRhdyrTJhju-_Z1nGV0g@mail.gmail.com>
2023-07-13 17:56   ` Jakub Kicinski
2023-07-20  6:55     ` Kalle Valo [this message]
2023-07-20 15:08       ` Jakub Kicinski
2023-07-20 17:14       ` Brian Norris
2023-07-21  7:15         ` Kalle Valo
2023-07-21 23:07           ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf9j3wd1.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=amitkarwar@gmail.com \
    --cc=ganapathi017@gmail.com \
    --cc=huxinming820@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pinkperfect2021@gmail.com \
    --cc=sharvari.harisangam@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.