From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFE87C77B75 for ; Wed, 17 May 2023 11:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AkNgtDV+IqH4IIOKZniHmDwTohclK8w9uHLqIcO4EwM=; b=LRH3BHyMRevf5k rRSoyEQiUx4YQpLJTAeCyHHngkbJcEca1CAzIxDt9K8n4jzCmMx0H2q054MF4N2BwZZ0RHgNOqGz1 iElBZmicWoMGPb81bSjbmK6beRKXi8v2ZrOJjdmIA24qvAk618ZKTcmyBy+kRV1ktone7nijT+gTl RCAs2FOPqzD6icAiC/j3JA/N/PZZTsqtHAsBexondNf3ntusEAYw37nyb+WOpHjZoDZJlUcndEIj0 rP9VV/iq5QPaseq2wzbnJxlU+CNwOYxIDUD/5G2u7FRpek4xb/Sie1Z6QiDywpLwUpoZQ5hx3xRdC TtGY/+YYM8Z4YtRhsPoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzEyV-009XCd-24; Wed, 17 May 2023 11:05:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzEyT-009XB2-04 for ath10k@lists.infradead.org; Wed, 17 May 2023 11:05:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8AFB76456C; Wed, 17 May 2023 11:05:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25507C4339C; Wed, 17 May 2023 11:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684321540; bh=Q72kVKGAqEzTgRn6ZNEGuvKnBS2ZxckUN41TA3GqR84=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FmP3GEO7SWi+Pb2HwSw3Wz2raaGTlyrfSH8A+80cKRGdWYw8WYLO309ufoiUT38tQ /SpSlpmEcAerb0UVvwmmi72UnBVO+Bi+u7H2rVQRl9D1Ourxu7gj/YLsSu8KtCy+YM kezchvkccrzPk0lUlDFHtotlzRuxOqYcNRQymdJlL6WodoLvz34fLJuCzuEdmedMh6 NneC3fSVpvXBVlrFwCdlP7uAR8PMfNr6RWwYEOVz+CT8gg0Ws1dAihLyQ8zLRavbta +42Cse/M6+Xfb1KigOW65c4jcsHk1+qEJrd47jAJIyVQxX5+DrHbuVzu5yHGK4Micy VG8eZZ0piI9PA== From: Kalle Valo To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Emmanuel Grumbach , "Rafael J . Wysocki" , Heiner Kallweit , Lukas Wunner , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Kazior , Janusz Dziedzic , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dean Luick , Andy Shevchenko , stable@vger.kernel.org Subject: Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL References: <20230517105235.29176-1-ilpo.jarvinen@linux.intel.com> <20230517105235.29176-10-ilpo.jarvinen@linux.intel.com> Date: Wed, 17 May 2023 14:05:33 +0300 In-Reply-To: <20230517105235.29176-10-ilpo.jarvinen@linux.intel.com> ("Ilpo \=\?utf-8\?Q\?J\=C3\=A4rvinen\=22's\?\= message of "Wed, 17 May 2023 13:52:35 +0300") Message-ID: <87sfbvkyki.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_040541_097144_DEB21986 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org SWxwbyBKw6RydmluZW4gPGlscG8uamFydmluZW5AbGludXguaW50ZWwuY29tPiB3cml0ZXM6Cgo+ IERvbid0IGFzc3VtZSB0aGF0IG9ubHkgdGhlIGRyaXZlciB3b3VsZCBiZSBhY2Nlc3NpbmcgTE5L Q1RMLiBBU1BNCj4gcG9saWN5IGNoYW5nZXMgY2FuIHRyaWdnZXIgd3JpdGUgdG8gTE5LQ1RMIG91 dHNpZGUgb2YgZHJpdmVyJ3MgY29udHJvbC4KPgo+IFVzZSBSTVcgY2FwYWJpbGl0eSBhY2Nlc3Nv cnMgd2hpY2ggZG9lcyBwcm9wZXIgbG9ja2luZyB0byBhdm9pZCBsb3NpbmcKPiBjb25jdXJyZW50 IHVwZGF0ZXMgdG8gdGhlIHJlZ2lzdGVyIHZhbHVlLiBPbiByZXN0b3JlLCBjbGVhciB0aGUgQVNQ TUMKPiBmaWVsZCBwcm9wZXJseS4KPgo+IEZpeGVzOiA3NmQ4NzBlZDA5YWIgKCJhdGgxMGs6IGVu YWJsZSBBU1BNIikKPiBTdWdnZXN0ZWQtYnk6IEx1a2FzIFd1bm5lciA8bHVrYXNAd3VubmVyLmRl Pgo+IFNpZ25lZC1vZmYtYnk6IElscG8gSsOkcnZpbmVuIDxpbHBvLmphcnZpbmVuQGxpbnV4Lmlu dGVsLmNvbT4KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwoKQWNrZWQtYnk6IEthbGxlIFZh bG8gPGt2YWxvQGtlcm5lbC5vcmc+CgotLSAKaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9w cm9qZWN0L2xpbnV4LXdpcmVsZXNzL2xpc3QvCgpodHRwczovL3dpcmVsZXNzLndpa2kua2VybmVs Lm9yZy9lbi9kZXZlbG9wZXJzL2RvY3VtZW50YXRpb24vc3VibWl0dGluZ3BhdGNoZXMKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5n IGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F912C77B7F for ; Wed, 17 May 2023 11:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231190AbjEQLG0 (ORCPT ); Wed, 17 May 2023 07:06:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230522AbjEQLGK (ORCPT ); Wed, 17 May 2023 07:06:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 491457A98; Wed, 17 May 2023 04:05:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 968976457B; Wed, 17 May 2023 11:05:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25507C4339C; Wed, 17 May 2023 11:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684321540; bh=Q72kVKGAqEzTgRn6ZNEGuvKnBS2ZxckUN41TA3GqR84=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FmP3GEO7SWi+Pb2HwSw3Wz2raaGTlyrfSH8A+80cKRGdWYw8WYLO309ufoiUT38tQ /SpSlpmEcAerb0UVvwmmi72UnBVO+Bi+u7H2rVQRl9D1Ourxu7gj/YLsSu8KtCy+YM kezchvkccrzPk0lUlDFHtotlzRuxOqYcNRQymdJlL6WodoLvz34fLJuCzuEdmedMh6 NneC3fSVpvXBVlrFwCdlP7uAR8PMfNr6RWwYEOVz+CT8gg0Ws1dAihLyQ8zLRavbta +42Cse/M6+Xfb1KigOW65c4jcsHk1+qEJrd47jAJIyVQxX5+DrHbuVzu5yHGK4Micy VG8eZZ0piI9PA== From: Kalle Valo To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Emmanuel Grumbach , "Rafael J . Wysocki" , Heiner Kallweit , Lukas Wunner , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Kazior , Janusz Dziedzic , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dean Luick , Andy Shevchenko , stable@vger.kernel.org Subject: Re: [PATCH v2 9/9] wifi: ath10k: Use RMW accessors for changing LNKCTL References: <20230517105235.29176-1-ilpo.jarvinen@linux.intel.com> <20230517105235.29176-10-ilpo.jarvinen@linux.intel.com> Date: Wed, 17 May 2023 14:05:33 +0300 In-Reply-To: <20230517105235.29176-10-ilpo.jarvinen@linux.intel.com> ("Ilpo \=\?utf-8\?Q\?J\=C3\=A4rvinen\=22's\?\= message of "Wed, 17 May 2023 13:52:35 +0300") Message-ID: <87sfbvkyki.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Ilpo J=C3=A4rvinen writes: > Don't assume that only the driver would be accessing LNKCTL. ASPM > policy changes can trigger write to LNKCTL outside of driver's control. > > Use RMW capability accessors which does proper locking to avoid losing > concurrent updates to the register value. On restore, clear the ASPMC > field properly. > > Fixes: 76d870ed09ab ("ath10k: enable ASPM") > Suggested-by: Lukas Wunner > Signed-off-by: Ilpo J=C3=A4rvinen > Cc: stable@vger.kernel.org Acked-by: Kalle Valo --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes