From: Baruch Siach <baruch@tkos.co.il>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org, Alex Shi <alexs@kernel.org>,
Yanteng Si <siyanteng@loongson.cn>
Subject: Re: [PATCH] docs: dt: fix documented Primecell compatible string
Date: Mon, 24 Apr 2023 10:24:59 +0300 [thread overview]
Message-ID: <87sfcpbuwo.fsf@tarshish> (raw)
In-Reply-To: <8ced22f59980fdfdae869acb91119dadd34987c0.1672847681.git.baruch@tkos.co.il>
Hi Rob, Krzysztof,
On Wed, Jan 04 2023, Baruch Siach wrote:
> Only arm,primecell is documented as compatible string for Primecell
> peripherals. Current code agrees with that.
I guess this fell between the cracks. I can't find this patch in
patchwork. Maybe the Chinese text made patchwork reject this path. But
the email is archived at lore:
https://lore.kernel.org/linux-devicetree/8ced22f59980fdfdae869acb91119dadd34987c0.1672847681.git.baruch@tkos.co.il/
Should I send separate patches for the main document and its
translation?
baruch
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> Documentation/devicetree/usage-model.rst | 2 +-
> Documentation/translations/zh_CN/devicetree/usage-model.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/usage-model.rst b/Documentation/devicetree/usage-model.rst
> index b6a287955ee5..0717426856b2 100644
> --- a/Documentation/devicetree/usage-model.rst
> +++ b/Documentation/devicetree/usage-model.rst
> @@ -415,6 +415,6 @@ When using the DT, this creates problems for of_platform_populate()
> because it must decide whether to register each node as either a
> platform_device or an amba_device. This unfortunately complicates the
> device creation model a little bit, but the solution turns out not to
> -be too invasive. If a node is compatible with "arm,amba-primecell", then
> +be too invasive. If a node is compatible with "arm,primecell", then
> of_platform_populate() will register it as an amba_device instead of a
> platform_device.
> diff --git a/Documentation/translations/zh_CN/devicetree/usage-model.rst
> b/Documentation/translations/zh_CN/devicetree/usage-model.rst
> index c6aee82c7e6e..19ba4ae0cd81 100644
> --- a/Documentation/translations/zh_CN/devicetree/usage-model.rst
> +++ b/Documentation/translations/zh_CN/devicetree/usage-model.rst
> @@ -325,6 +325,6 @@ Primecell设备。然而,棘手的一点是,AMBA总线上的所有设备并
>
> 当使用DT时,这给of_platform_populate()带来了问题,因为它必须决定是否将
> 每个节点注册为platform_device或amba_device。不幸的是,这使设备创建模型
> -变得有点复杂,但解决方案原来并不是太具有侵略性。如果一个节点与“arm,amba-primecell”
> +变得有点复杂,但解决方案原来并不是太具有侵略性。如果一个节点与“arm,primecell”
> 兼容,那么of_platform_populate()将把它注册为amba_device而不是
> platform_device。
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2023-04-24 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 15:54 [PATCH] docs: dt: fix documented Primecell compatible string Baruch Siach
2023-04-24 7:24 ` Baruch Siach [this message]
2023-04-24 8:16 ` Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfcpbuwo.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=alexs@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=robh+dt@kernel.org \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.