From: "Alex Bennée" <alex.bennee@linaro.org>
To: Karim Taha <kariem.taha2.7@gmail.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Warner Losh" <imp@bsdimp.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 01/11] Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
Date: Fri, 21 Apr 2023 18:21:03 +0100 [thread overview]
Message-ID: <87sfct9mm6.fsf@linaro.org> (raw)
In-Reply-To: <CAHNti2dQnbmAO5hTyb6krd8tSMCqXDp80BEcd0ZUHXmk0LZS-w@mail.gmail.com>
Karim Taha <kariem.taha2.7@gmail.com> writes:
> On Fri, Apr 21, 2023 at 9:17 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Fri, Apr 21, 2023 at 07:22:45AM +0200, Karim Taha wrote:
> > From: Warner Losh <imp@bsdimp.com>
> >
> > Allow guest_base to be initialized on 64-bit hosts, the initial value is used by g2h_untagged function
> defined in include/exec/cpu_ldst.h
>
> This commit message is all incorrectly structured I'm afraid.
>
> There needs to a short 1 line summary, then a blank line,
> then the full commit description text, then a blank line,
> then the Signed-off-by tag(s).
>
> Also if you're sending work done by Warner (as the From
> tag suggests), then we would expect to see Warner's own
> Signed-off-by tag, in addition to your own Signed-off-by.
<snip>
>
> Alright, thanks for the commit formatting tips, I resent the patch series, with my signed off by tag and the
> author signed off by tags as well.
Hmm something has gone wrong. Was this sent with a plain git-send-email
or using a tool like git-publish?
Can you point to a branch?
>
> Best regards,
> Karim
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-04-21 17:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 5:22 [PATCH 00/11] Contribution task implementations, for the 'FreeBSD user emulation improvements' project Karim Taha
2023-04-21 5:22 ` [PATCH 01/11] Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com> Karim Taha
2023-04-21 7:17 ` Daniel P. Berrangé
2023-04-21 16:56 ` Karim Taha
2023-04-21 17:21 ` Alex Bennée [this message]
2023-04-21 22:40 ` Karim Taha
[not found] ` <CANCZdfr=32YFV0mHJxJn0F3aNUQT5YccQdRYdtq1au6BFF8WHw@mail.gmail.com>
2023-04-22 19:23 ` Karim Taha
2023-04-24 9:14 ` Alex Bennée
2023-04-21 5:22 ` [PATCH 02/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 03/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 04/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 05/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 06/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 07/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 08/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 09/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 10/11] " Karim Taha
2023-04-21 5:22 ` [PATCH 11/11] " Karim Taha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfct9mm6.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=imp@bsdimp.com \
--cc=kariem.taha2.7@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.