From: Fabiano Rosas <farosas@suse.de>
To: Harsh Prateek Bora <harshpb@linux.ibm.com>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org, danielhb413@gmail.com
Subject: Re: [PATCH 3/5] ppc: spapr: assert early rather late in h_enter_nested()
Date: Fri, 14 Apr 2023 08:55:29 -0300 [thread overview]
Message-ID: <87sfd2ispa.fsf@suse.de> (raw)
In-Reply-To: <20230331065344.112341-4-harshpb@linux.ibm.com>
Harsh Prateek Bora <harshpb@linux.ibm.com> writes:
> Currently, it asserts very late in the code flow if lpid is already initialized.
That's not about initializing. It is about making sure the LPIDR is
0. Which has a specific meaning according to the ISA.
> Ideally, it should assert in the beginning if that is the case. This patch
> brings assert check in the beginning alongwith the related initialization.
>
Maybe just leave it where it is. There's not much to gain from moving this.
next prev parent reply other threads:[~2023-04-14 11:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 6:53 [PATCH 0/5] Cleanup [h_enter|spapr_exit]_nested routines Harsh Prateek Bora
2023-03-31 6:53 ` [PATCH 1/5] ppc: spapr: cleanup cr get/store with helper routines Harsh Prateek Bora
2023-04-14 11:40 ` Fabiano Rosas
2023-04-17 6:54 ` Harsh Prateek Bora
2023-03-31 6:53 ` [PATCH 2/5] ppc: spapr: cleanup h_enter_nested() " Harsh Prateek Bora
2023-04-14 11:53 ` Fabiano Rosas
2023-04-17 7:02 ` Harsh Prateek Bora
2023-03-31 6:53 ` [PATCH 3/5] ppc: spapr: assert early rather late in h_enter_nested() Harsh Prateek Bora
2023-04-14 11:55 ` Fabiano Rosas [this message]
2023-04-17 7:15 ` Harsh Prateek Bora
2023-03-31 6:53 ` [PATCH 4/5] ppc: spapr: cleanup spapr_exit_nested() with helper routines Harsh Prateek Bora
2023-04-14 11:58 ` Fabiano Rosas
2023-04-17 7:17 ` Harsh Prateek Bora
2023-03-31 6:53 ` [PATCH 5/5] MAINTAINERS: Adding myself in the list for ppc/spapr Harsh Prateek Bora
2023-04-14 11:57 ` Daniel Henrique Barboza
2023-04-17 7:21 ` Harsh Prateek Bora
2023-03-31 10:39 ` [PATCH 0/5] Cleanup [h_enter|spapr_exit]_nested routines Cédric Le Goater
2023-03-31 11:06 ` Daniel Henrique Barboza
2023-04-11 4:15 ` Harsh Prateek Bora
2023-04-14 12:04 ` Fabiano Rosas
2023-04-17 7:21 ` Harsh Prateek Bora
2023-04-17 10:10 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfd2ispa.fsf@suse.de \
--to=farosas@suse.de \
--cc=danielhb413@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.