From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D2B9C4167B for ; Sun, 1 Jan 2023 22:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=17sVAJmfUj93y3H9ySKuLUdnEGHAWrZ0D/dd/H3yVao=; b=bjD7eOy+nNZM0pClErBwyI3iYd b7Mt4JOTq1pKRiwHO7SdQycdeEDXeGHcOHl8A2mwtKgoNf9uXrMJ4vEZ6Umd9BkQ3MSGcshkg/uxy VokMeiXhIwiyhLlyaUz+OEewV0tz6ScYllCnzsEy/5gHIOgXWyhaFEh+g/ZGps6iep6C/lS86x7EK QU24VSzFA/FQqORtgZWf5nYseqnVBnbMTg/epaGZZboKuYAf/BUh2wKLnDa4JGqXWXm2llDIlxecG WcXOEQcuTWF2LkMAXZYRRmPbiDAIo/roo36TyE9xihQ1l3pDuB4X8/Zva0RNQhRSGnwPmEb+3zg0K +uBbQuJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pC78K-0062wZ-S0; Sun, 01 Jan 2023 22:48:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pC75b-0061B2-7o; Sun, 01 Jan 2023 22:46:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3E6060C0B; Sun, 1 Jan 2023 22:45:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05DBBC433D2; Sun, 1 Jan 2023 22:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672613157; bh=puCrFpi65CZPLTug1sTI/K7FXDEL7ysdynSiNUjiHjM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lLuv2sI0twxXXwFtob+q3T/m/TaGKcrYXNijV3Yd+gxuCFoTlwB4RqPisvZ8VjxmT +KBsHScrw7VSVqr/YaZPUB26i9YBmBMeonrZOZNCWQapTLT2PryaksSlfu9P3w9JLr XVFvBCAjOFlMoQaPwqJBDN9z2c3aNlyTJu30Meg/9AFlRKZ+Oob1jYFMz5iXcUZFJ2 glY/2+LvhrNXADNQIAroHgiiSCo6CAsX8aabbdOynUdlG6xkcqypvupo5h9/vlN2q7 gjbKK4wxKab8YVZYIbelu350fB+b2nefUkky888RkJouJkQ1koy4ZcFd2Ct8o/kBti 48PFeHB2b/ZgA== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pC75W-00GEJt-OM; Sun, 01 Jan 2023 22:45:54 +0000 Date: Sun, 01 Jan 2023 22:44:39 +0000 Message-ID: <87sfgteuy0.wl-maz@kernel.org> From: Marc Zyngier To: Bernhard =?UTF-8?B?Um9zZW5rcsOkbnplcg==?= Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, matthias.bgg@gmail.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, gregkh@linuxfoundation.org, chunfeng.yun@mediatek.com, linus.walleij@linaro.org, lee@kernel.org, tglx@linutronix.de, angelogioacchino.delregno@collabora.com Subject: Re: [PATCH v6 7/7] arm64: dts: mediatek: Initial mt8365-evk support In-Reply-To: References: <20221230203541.146807-1-bero@baylibre.com> <20221230203541.146807-8-bero@baylibre.com> <87v8lsect3.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: bero@baylibre.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, matthias.bgg@gmail.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, gregkh@linuxfoundation.org, chunfeng.yun@mediatek.com, linus.walleij@linaro.org, lee@kernel.org, tglx@linutronix.de, angelogioacchino.delregno@collabora.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230101_144559_428795_2322D575 X-CRM114-Status: GOOD ( 24.21 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, 01 Jan 2023 21:57:58 +0000, Bernhard Rosenkr=C3=A4nzer wrote: >=20 > On Fri, Dec 30, 2022 at 11:41 PM Marc Zyngier wrote: > > > + gic: interrupt-controller@c000000 { > > > + compatible =3D "arm,gic-v3"; > > > + #interrupt-cells =3D <4>; > > > > Why 4 cells? All the SPIs routed via sysirq are perfectly happy with 3 > > cells, and all the PPIs have 0 for the 4th cell (none of them use any > > form of partitioning that'd require 4 cells). So where is this coming > > from? >=20 > It's coming from the SoC vendor kernel (and went unnoticed because > it happens to work). Will send an updated version that does the > right thing instead. I've been running it most of the day, so far > looking good. >=20 > > > + interrupt-parent =3D <&gic>; > > > + interrupt-controller; > > > + reg =3D <0 0x0c000000 0 0x80000>, <0 0x0c080000= 0 0x80000>; > > > + > > > > The first region is obviously wrong (512kB for the distributor? > > that's... most generous, but the architecture states that it is 64kB, > > and that's wasteful enough). > > > > This is also missing the GICC/GICH/GICV regions that Cortex-A53 > > implements, and that must be provided as per the binding. >=20 > This was also taken from the vendor kernel; unfortunately neiter the > datasheet for the SoC not the vendor kernel specifies the addresses > for GICC/GICH/GICV. > I've "guessed" based on what's in similar SoCs (MT8183, MT7986a) in > v7; this seems to work (boots, kvm initializes hyp mode properly). Please don't "guess", because this adds zero value, and we might as well run with the vendor crap instead. Read CBAR_EL1, and use this value to construct the memory map, as per the A53 TRM. Just booting with KVM enabled means nothing, as this is solely used at VM run time. You need run a full VM with GIC-2 emulation. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08903C4167B for ; Sun, 1 Jan 2023 22:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TEXrfV3EMj3fYBRHAqobBymjXHXwtS7K8oePFNw6xL8=; b=nN3EGC5EWekjg6 9YE/9wF9jej3OUjm9uQtW75EtmC/OsLFaP2UqKuL+wfcnhPb/rjr4tN4qEveQBVo5TEfTwAp7SUHh TmjJhjlKsh8LGxCqE1NnEG3qtfz7jSAuW8AjGvEKKAVRt2V4xy/Zsb+mLLskM5Vesfp23DABVpUNm XUpy94dn256ps5tYwQp3Ps3dSt9mVSpwGkGJQGcOoO8R4z6ZeHKp/anviA2BmKm2QRgccAJewsUfm bccQ0UnGV6ewczY7yk6zirQOHV3mRqSE69hZsdYs2Sm1S4A2TCj8MljpdTU9YScDlZMnmO+Y/JfhR bIFcPPdstYpcEiO3TFmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pC75v-0061mG-IO; Sun, 01 Jan 2023 22:46:19 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pC75b-0061B2-7o; Sun, 01 Jan 2023 22:46:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3E6060C0B; Sun, 1 Jan 2023 22:45:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05DBBC433D2; Sun, 1 Jan 2023 22:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672613157; bh=puCrFpi65CZPLTug1sTI/K7FXDEL7ysdynSiNUjiHjM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lLuv2sI0twxXXwFtob+q3T/m/TaGKcrYXNijV3Yd+gxuCFoTlwB4RqPisvZ8VjxmT +KBsHScrw7VSVqr/YaZPUB26i9YBmBMeonrZOZNCWQapTLT2PryaksSlfu9P3w9JLr XVFvBCAjOFlMoQaPwqJBDN9z2c3aNlyTJu30Meg/9AFlRKZ+Oob1jYFMz5iXcUZFJ2 glY/2+LvhrNXADNQIAroHgiiSCo6CAsX8aabbdOynUdlG6xkcqypvupo5h9/vlN2q7 gjbKK4wxKab8YVZYIbelu350fB+b2nefUkky888RkJouJkQ1koy4ZcFd2Ct8o/kBti 48PFeHB2b/ZgA== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pC75W-00GEJt-OM; Sun, 01 Jan 2023 22:45:54 +0000 Date: Sun, 01 Jan 2023 22:44:39 +0000 Message-ID: <87sfgteuy0.wl-maz@kernel.org> From: Marc Zyngier To: Bernhard =?UTF-8?B?Um9zZW5rcsOkbnplcg==?= Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, matthias.bgg@gmail.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, gregkh@linuxfoundation.org, chunfeng.yun@mediatek.com, linus.walleij@linaro.org, lee@kernel.org, tglx@linutronix.de, angelogioacchino.delregno@collabora.com Subject: Re: [PATCH v6 7/7] arm64: dts: mediatek: Initial mt8365-evk support In-Reply-To: References: <20221230203541.146807-1-bero@baylibre.com> <20221230203541.146807-8-bero@baylibre.com> <87v8lsect3.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: bero@baylibre.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, matthias.bgg@gmail.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, gregkh@linuxfoundation.org, chunfeng.yun@mediatek.com, linus.walleij@linaro.org, lee@kernel.org, tglx@linutronix.de, angelogioacchino.delregno@collabora.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230101_144559_428795_2322D575 X-CRM114-Status: GOOD ( 24.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAwMSBKYW4gMjAyMyAyMTo1Nzo1OCArMDAwMCwKQmVybmhhcmQgUm9zZW5rcsOkbnpl ciA8YmVyb0BiYXlsaWJyZS5jb20+IHdyb3RlOgo+IAo+IE9uIEZyaSwgRGVjIDMwLCAyMDIyIGF0 IDExOjQxIFBNIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiArICAg ICAgICAgICAgIGdpYzogaW50ZXJydXB0LWNvbnRyb2xsZXJAYzAwMDAwMCB7Cj4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gImFybSxnaWMtdjMiOwo+ID4gPiArICAgICAg ICAgICAgICAgICAgICAgI2ludGVycnVwdC1jZWxscyA9IDw0PjsKPiA+Cj4gPiBXaHkgNCBjZWxs cz8gQWxsIHRoZSBTUElzIHJvdXRlZCB2aWEgc3lzaXJxIGFyZSBwZXJmZWN0bHkgaGFwcHkgd2l0 aCAzCj4gPiBjZWxscywgYW5kIGFsbCB0aGUgUFBJcyBoYXZlIDAgZm9yIHRoZSA0dGggY2VsbCAo bm9uZSBvZiB0aGVtIHVzZSBhbnkKPiA+IGZvcm0gb2YgcGFydGl0aW9uaW5nIHRoYXQnZCByZXF1 aXJlIDQgY2VsbHMpLiBTbyB3aGVyZSBpcyB0aGlzIGNvbWluZwo+ID4gZnJvbT8KPiAKPiBJdCdz IGNvbWluZyBmcm9tIHRoZSBTb0MgdmVuZG9yIGtlcm5lbCAoYW5kIHdlbnQgdW5ub3RpY2VkIGJl Y2F1c2UKPiBpdCBoYXBwZW5zIHRvIHdvcmspLiAgV2lsbCBzZW5kIGFuIHVwZGF0ZWQgdmVyc2lv biB0aGF0IGRvZXMgdGhlCj4gcmlnaHQgdGhpbmcgaW5zdGVhZC4gSSd2ZSBiZWVuIHJ1bm5pbmcg aXQgbW9zdCBvZiB0aGUgZGF5LCBzbyBmYXIKPiBsb29raW5nIGdvb2QuCj4gCj4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICBpbnRlcnJ1cHQtcGFyZW50ID0gPCZnaWM+Owo+ID4gPiArICAgICAg ICAgICAgICAgICAgICAgaW50ZXJydXB0LWNvbnRyb2xsZXI7Cj4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICByZWcgPSA8MCAweDBjMDAwMDAwIDAgMHg4MDAwMD4sIDwwIDB4MGMwODAwMDAgMCAw eDgwMDAwPjsKPiA+ID4gKwo+ID4KPiA+IFRoZSBmaXJzdCByZWdpb24gaXMgb2J2aW91c2x5IHdy b25nICg1MTJrQiBmb3IgdGhlIGRpc3RyaWJ1dG9yPwo+ID4gdGhhdCdzLi4uIG1vc3QgZ2VuZXJv dXMsIGJ1dCB0aGUgYXJjaGl0ZWN0dXJlIHN0YXRlcyB0aGF0IGl0IGlzIDY0a0IsCj4gPiBhbmQg dGhhdCdzIHdhc3RlZnVsIGVub3VnaCkuCj4gPgo+ID4gVGhpcyBpcyBhbHNvIG1pc3NpbmcgdGhl IEdJQ0MvR0lDSC9HSUNWIHJlZ2lvbnMgdGhhdCBDb3J0ZXgtQTUzCj4gPiBpbXBsZW1lbnRzLCBh bmQgdGhhdCBtdXN0IGJlIHByb3ZpZGVkIGFzIHBlciB0aGUgYmluZGluZy4KPiAKPiBUaGlzIHdh cyBhbHNvIHRha2VuIGZyb20gdGhlIHZlbmRvciBrZXJuZWw7IHVuZm9ydHVuYXRlbHkgbmVpdGVy IHRoZQo+IGRhdGFzaGVldCBmb3IgdGhlIFNvQyBub3QgdGhlIHZlbmRvciBrZXJuZWwgc3BlY2lm aWVzIHRoZSBhZGRyZXNzZXMKPiBmb3IgR0lDQy9HSUNIL0dJQ1YuCj4gSSd2ZSAiZ3Vlc3NlZCIg YmFzZWQgb24gd2hhdCdzIGluIHNpbWlsYXIgU29DcyAoTVQ4MTgzLCBNVDc5ODZhKSBpbgo+IHY3 OyB0aGlzIHNlZW1zIHRvIHdvcmsgKGJvb3RzLCBrdm0gaW5pdGlhbGl6ZXMgaHlwIG1vZGUgcHJv cGVybHkpLgoKUGxlYXNlIGRvbid0ICJndWVzcyIsIGJlY2F1c2UgdGhpcyBhZGRzIHplcm8gdmFs dWUsIGFuZCB3ZSBtaWdodCBhcwp3ZWxsIHJ1biB3aXRoIHRoZSB2ZW5kb3IgY3JhcCBpbnN0ZWFk LgoKUmVhZCBDQkFSX0VMMSwgYW5kIHVzZSB0aGlzIHZhbHVlIHRvIGNvbnN0cnVjdCB0aGUgbWVt b3J5IG1hcCwgYXMgcGVyCnRoZSBBNTMgVFJNLiBKdXN0IGJvb3Rpbmcgd2l0aCBLVk0gZW5hYmxl ZCBtZWFucyBub3RoaW5nLCBhcyB0aGlzIGlzCnNvbGVseSB1c2VkIGF0IFZNIHJ1biB0aW1lLiBZ b3UgbmVlZCBydW4gYSBmdWxsIFZNIHdpdGggR0lDLTIKZW11bGF0aW9uLgoKCU0uCgotLSAKV2l0 aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=