From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76D0EC46467 for ; Mon, 28 Nov 2022 13:39:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozeLU-0008Od-Ur; Mon, 28 Nov 2022 08:38:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozeLT-0008Ke-7Q for qemu-devel@nongnu.org; Mon, 28 Nov 2022 08:38:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozeLQ-0006aI-Rd for qemu-devel@nongnu.org; Mon, 28 Nov 2022 08:38:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669642728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jiFzm/k9soH6k/5lDy9A8EjXX5yB5yL456BE/nWSKik=; b=PYxk5han5gjHQWWfWmMy24Ur2fAqSp2nc6end2Itlf760qrytrQ/h5XA5PX04wIJAAJJTz 4tDRC1YiiEm/Zho6DPLDjuC42xIU4nLxPoo5yX2v8KCNPVotF2z7EX3gfU28W+9eb4oJzK qUfcQ3keNRka/OKW/R+S7bHxY+Qvt94= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-NGUNMhbANzS7V9xJhwshSA-1; Mon, 28 Nov 2022 08:38:46 -0500 X-MC-Unique: NGUNMhbANzS7V9xJhwshSA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 479D238123A1; Mon, 28 Nov 2022 13:38:46 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18D66C15BA4; Mon, 28 Nov 2022 13:38:46 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DDE6921E6921; Mon, 28 Nov 2022 14:38:42 +0100 (CET) From: Markus Armbruster To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, mst@redhat.com, marcel.apfelbaum@gmail.com Subject: Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI References: <20221128080202.2570543-1-armbru@redhat.com> <20221128080202.2570543-6-armbru@redhat.com> Date: Mon, 28 Nov 2022 14:38:42 +0100 In-Reply-To: (David Alan Gilbert's message of "Mon, 28 Nov 2022 12:24:55 +0000") Message-ID: <87sfi3p5b1.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org "Dr. David Alan Gilbert" writes: > * Markus Armbruster (armbru@redhat.com) wrote: >> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when >> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when >> !CONFIG_PCI. Build pci-hmp-cmds.c that way, too. >> >> Signed-off-by: Markus Armbruster > > Had you considered wrapping the hmp-commands-info.hx entry > with a #if defined instead? No. Would you prefer that? Code containing #ifdef CONFIG_PCI is target-dependent. Looks like the affected monitor code already is, so no new headaches. Aside: splitting off its target-independent parts could be nice. Not today. [...]