Re: [PATCH v2 net 7/7] hsr: Use a single struct for self_node.

[Kurt Kanzenbach <kurt@linutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

On Mon Nov 21 2022, Sebastian Andrzej Siewior wrote:
> self_node_db is a list_head with one entry of struct hsr_node. The
> purpose is to hold the two MAC addresses of the node itself.
> It is convenient to recycle the structure. However having a list_head
> and fetching always the first entry is not really optimal.
>
> Created a new data strucure contaning the two MAC addresses named
> hsr_self_node. Access that structured like an RCU protected pointer so
                             ^ structure

> it can be replaced on the fly withou blocking the reader.
                               ^ without

>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Lacks a Fixes tag. Looks rather like an optimization than a bugfix? So,
maybe this one should go to net-next instead.

[snip]

> +struct hsr_self_node {
> +	unsigned char	macaddress_A[6];
                                    ^ ETH_ALEN

> +	unsigned char	macaddress_B[6];
                                    ^ ETH_ALEN
> +	struct rcu_head	rcu_head;
> +};
> +

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]