All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: gregory.greenman@intel.com
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	Mordechay Goodstein <mordechay.goodstein@intel.com>
Subject: Re: [PATCH 4/9] wifi: iwlwifi: mvm: add support for EHT 1K aggregation size
Date: Mon, 21 Nov 2022 18:07:52 +0200	[thread overview]
Message-ID: <87sfic8f53.fsf@kernel.org> (raw)
In-Reply-To: <20221120185147.d82e3d7bf651.Ie4d90c376c822694f4523ff0fb5731f20004c24d@changeid> (gregory greenman's message of "Sun, 20 Nov 2022 19:00:34 +0200")

gregory.greenman@intel.com writes:

> From: Mordechay Goodstein <mordechay.goodstein@intel.com>
>
> In 11be we can receive 1K aggregation size so update our max HW rx
> aggregation for mac80211 usage.
>
> Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
> Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> index 9699433137bc..310eb3fde386 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> @@ -1077,6 +1077,8 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg,
>  	static const u8 no_reclaim_cmds[] = {
>  		TX_CMD,
>  	};
> +	u32 max_agg = trans->trans_cfg->device_family >= IWL_DEVICE_FAMILY_BZ ?
> +			   IEEE80211_MAX_AMPDU_BUF_EHT : IEEE80211_MAX_AMPDU_BUF_HE;

IMHO a proper if statement is cleaner than this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2022-11-21 16:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-20 17:00 [PATCH 0/9] wifi: iwlwifi: updates intended for v6.2 2022-11-20 gregory.greenman
2022-11-20 17:00 ` [PATCH 1/9] wifi: iwlwifi: mvm: Advertise EHT capabilities gregory.greenman
2022-11-21 16:05   ` Kalle Valo
2022-11-22 13:48     ` Arend van Spriel
2022-11-22 15:25       ` Kalle Valo
2022-11-20 17:00 ` [PATCH 2/9] wifi: iwlwifi: mvm: support 320 MHz PHY configuration gregory.greenman
2022-11-20 17:00 ` [PATCH 3/9] wifi: iwlwifi: rs: add support for parsing max MCS per NSS/BW in 11be gregory.greenman
2022-11-20 17:00 ` [PATCH 4/9] wifi: iwlwifi: mvm: add support for EHT 1K aggregation size gregory.greenman
2022-11-21 16:07   ` Kalle Valo [this message]
2022-11-20 17:00 ` [PATCH 5/9] wifi: iwlwifi: mvm: support PPE Thresholds for EHT gregory.greenman
2022-11-20 17:00 ` [PATCH 6/9] wifi: iwlwifi: mvm: set HE PHY bandwidth according to band gregory.greenman
2022-11-20 17:00 ` [PATCH 7/9] wifi: iwlwifi: mvm: advertise 320 MHz in 6 GHz only conditionally gregory.greenman
2022-11-20 17:00 ` [PATCH 8/9] wifi: iwlwifi: nvm-parse: support A-MPDU in EHT 2.4 GHz gregory.greenman
2022-11-20 17:00 ` [PATCH 9/9] wifi: iwlwifi: nvm: Update EHT capabilities for GL device gregory.greenman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfic8f53.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=gregory.greenman@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mordechay.goodstein@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.