All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: Yang Xu <xuyang2018.jy@cn.fujitsu.com>,
	Alessandro Carminati <alessandro.carminati@gmail.com>,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] doc/c-test-api.txt: Improve tst_find_backing_dev() doc
Date: Mon, 14 Nov 2022 10:25:10 +0000	[thread overview]
Message-ID: <87sfilu920.fsf@suse.de> (raw)
In-Reply-To: <20221110175236.32094-3-pvorel@suse.cz>

Hello,

Petr Vorel <pvorel@suse.cz> writes:

> Doc added in 606903cf8 was too complicated. Also there was repeating
> sentence, typo 'unevent'.
>
> While at it, fix also 'voud' typo from 9343d0486.
>
> Fixes: 606903cf8 ("c-test-api: Documentation updated")
> Fixes: 9343d0486 ("tst_device: Add new api tst_find_backing_dev(path, dev)")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Thanks

Acked-by: Richard Palethorpe <rpalethorpe@suse.com>

> ---
>  doc/c-test-api.txt | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/doc/c-test-api.txt b/doc/c-test-api.txt
> index 8844d9f2f..834a342fd 100644
> --- a/doc/c-test-api.txt
> +++ b/doc/c-test-api.txt
> @@ -1075,12 +1075,9 @@ is created for that intention.
>  void tst_find_backing_dev(const char *path, char *dev);
>  -------------------------------------------------------------------------------
>  
> -This function finds the block dev that this path belongs to, it uses stat function
> -to get the major/minor number of the path.
> -This function finds the block dev that this path belongs to, it uses the unevent
> -file in sysfs to find the device name. It needs to discriminate between btrfs
> -and not btrfs. For non btrfs filesystems it uses the minor, major numbers. For
> -btrfs it uses the fs uuid.
> +This function finds the block dev that this path belongs to, using uevent in sysfs.
> +For Btrfs it uses '/sys/fs/btrfs/UUID/devices/DEV_NAME/uevent'; for other
> +filesystems it uses '/sys/dev/block/MAJOR:MINOR/uevent'.
>  
>  [source,c]
>  -------------------------------------------------------------------------------


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-11-14 10:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 17:52 [LTP] [PATCH 0/2] tst_find_backing_dev() fixes Petr Vorel
2022-11-10 17:52 ` [LTP] [PATCH 1/2] lib/tst_device: Remove unused count_match_len() Petr Vorel
2022-11-14 10:23   ` Richard Palethorpe
2022-11-10 17:52 ` [LTP] [PATCH 2/2] doc/c-test-api.txt: Improve tst_find_backing_dev() doc Petr Vorel
2022-11-14 10:25   ` Richard Palethorpe [this message]
2022-11-14 15:09     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfilu920.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=alessandro.carminati@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    --cc=xuyang2018.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.