From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0D28C4332F for ; Tue, 18 Oct 2022 13:00:45 +0000 (UTC) Received: from localhost ([::1]:55392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okmCw-0003GV-3p for qemu-devel@archiver.kernel.org; Tue, 18 Oct 2022 09:00:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okm94-0001z3-24 for qemu-devel@nongnu.org; Tue, 18 Oct 2022 08:56:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:20455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okm92-0007MW-2T for qemu-devel@nongnu.org; Tue, 18 Oct 2022 08:56:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666097790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LjYjjcSYS3yCvsC0dxgtTRkw0ouZxE34JUw1fQ602y0=; b=hChCf8NNFXZ1iZ/fTwdNFfz4BiaXJKQSbKLs2AFHE6MmjBwOFWMKtcV/Ykh8rm7qicCDtb 3hZ4S67YEf65Jy9kioLGDwVlGIGjzwW1sD+SuXTh15XSBHMQjTChn4cYIq8YFO067p2tYH wTh5wa1H1pKZj9LJBxHPxvtLymyhpPg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-EUogkakyNzKze1SYkKfgVg-1; Tue, 18 Oct 2022 08:56:29 -0400 X-MC-Unique: EUogkakyNzKze1SYkKfgVg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 41949380670C; Tue, 18 Oct 2022 12:55:59 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11C0A1111C61; Tue, 18 Oct 2022 12:55:59 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C1C3521E6936; Tue, 18 Oct 2022 14:55:57 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, michael.roth@amd.com, jsnow@redhat.com, eblake@redhat.com, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Daniel P . =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH v2 09/28] qapi char: Elide redundant has_FOO in generated C References: <20221018062849.3420573-1-armbru@redhat.com> <20221018062849.3420573-10-armbru@redhat.com> <11955623-1be2-d19d-8720-9032be63b423@linaro.org> Date: Tue, 18 Oct 2022 14:55:57 +0200 In-Reply-To: <11955623-1be2-d19d-8720-9032be63b423@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Tue, 18 Oct 2022 14:14:06 +0200") Message-ID: <87sfjl2sv6.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.256, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > On 18/10/22 08:28, Markus Armbruster wrote: >> The has_FOO for pointer-valued FOO are redundant, except for arrays. >> They are also a nuisance to work with. Recent commit "qapi: Start to >> elide redundant has_FOO in generated C" provided the means to elide >> them step by step. This is the step for qapi/char.json. >> Said commit explains the transformation in more detail. The invariant >> violations mentioned there do not occur here. >> Cc: Marc-Andr=C3=A9 Lureau >> Cc: Paolo Bonzini >> Signed-off-by: Markus Armbruster >> Reviewed-by: Daniel P. Berrang=C3=A9 >> --- >> chardev/char-file.c | 4 ++-- >> chardev/char-socket.c | 10 ++++------ >> chardev/char-udp.c | 1 - >> chardev/char.c | 6 +----- >> tests/unit/test-char.c | 1 - >> scripts/qapi/schema.py | 1 - >> 6 files changed, 7 insertions(+), 16 deletions(-) > > Eventually s/char/chardev/ in subject. ACK > Reviewed-by: Philippe Mathieu-Daud=C3=A9 Thanks!