From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 196FCECAAD3 for ; Wed, 14 Sep 2022 09:29:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 94B114092A; Wed, 14 Sep 2022 09:29:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 94B114092A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r38GCKquxQou; Wed, 14 Sep 2022 09:29:46 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 84615402EC; Wed, 14 Sep 2022 09:29:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 84615402EC Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id BCEDD1BF355 for ; Wed, 14 Sep 2022 09:29:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A485A402EC for ; Wed, 14 Sep 2022 09:29:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org A485A402EC X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u4zenttltK-u for ; Wed, 14 Sep 2022 09:29:42 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 88CE340266 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by smtp4.osuosl.org (Postfix) with ESMTPS id 88CE340266 for ; Wed, 14 Sep 2022 09:29:42 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id D639CE0014; Wed, 14 Sep 2022 09:29:38 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1oYOi9-0046lG-75; Wed, 14 Sep 2022 11:29:37 +0200 From: Peter Korsgaard To: Quentin Schulz References: <20220802123559.2514433-1-foss+buildroot@0leil.net> Date: Wed, 14 Sep 2022 11:29:37 +0200 In-Reply-To: <20220802123559.2514433-1-foss+buildroot@0leil.net> (Quentin Schulz's message of "Tue, 2 Aug 2022 14:35:59 +0200") Message-ID: <87sfkuqp6m.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH] Makefile: error out printvars target when VARS is empty or unset X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Quentin Schulz , yann.morin.1998@free.fr, buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Quentin" == Quentin Schulz writes: > From: Quentin Schulz > printvars returns nothing when VARS is not passed or empty. This is done > on purpose, see commit fd5bd12379dc ("Makefile: printvars: don't print > anything when VARS is not set"). > An error message making explicit what is required from the user in order > to use printvars is however better than silently doing nothing. > This adds a check for a non-empty VARS variable. > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz Committed to 2022.05.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot