From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, "Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Yanan Wang" <wangyanan55@huawei.com>
Subject: Re: [PATCH 4/5] migration: Make find_dirty_block() return a single parameter
Date: Tue, 26 Jul 2022 18:23:31 +0200 [thread overview]
Message-ID: <87sfmnderg.fsf@secure.mitica> (raw)
In-Reply-To: <YsQ0fc67PKePt3rS@work-vm> (David Alan Gilbert's message of "Tue, 5 Jul 2022 13:54:21 +0100")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Juan Quintela (quintela@redhat.com) wrote:
>> We used to return two bools, just return a single int with the
>> following meaning:
>>
>> old return / again / new return
>> false false 0
>> false true 1
>> true true 2 /* We don't care about again at all */
>
> We shouldn't use magic numbers; if you want to return it in a single
> value then it should be an enum so it is clear.
I need to also return an error in the following patches.
I am not sure if it clearer to try to change to an enum.
Will try and see.
Later, Juan.
next prev parent reply other threads:[~2022-07-26 17:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 14:05 [PATCH 0/5] Eliminate multifd flush Juan Quintela
2022-06-21 14:05 ` [PATCH 1/5] multifd: Create property multifd-sync-each-iteration Juan Quintela
2022-06-30 14:34 ` Dr. David Alan Gilbert
2022-07-04 16:07 ` Juan Quintela
2022-07-05 12:19 ` Dr. David Alan Gilbert
2022-06-21 14:05 ` [PATCH 2/5] multifd: Put around all sync calls tests for each iteration Juan Quintela
2022-07-05 12:20 ` Dr. David Alan Gilbert
2022-06-21 14:05 ` [PATCH 3/5] migration: Simplify ram_find_and_save_block() Juan Quintela
2022-07-05 12:51 ` Dr. David Alan Gilbert
2022-06-21 14:05 ` [PATCH 4/5] migration: Make find_dirty_block() return a single parameter Juan Quintela
2022-07-05 12:54 ` Dr. David Alan Gilbert
2022-07-26 16:23 ` Juan Quintela [this message]
2022-07-28 9:07 ` Dr. David Alan Gilbert
2022-06-21 14:05 ` [PATCH 5/5] multifd: Only sync once each full round of memory Juan Quintela
2022-07-01 2:29 ` Leonardo Brás
2022-07-04 16:18 ` Juan Quintela
2022-07-05 13:56 ` Dr. David Alan Gilbert
2022-07-05 14:34 ` Daniel P. Berrangé
2022-07-05 15:13 ` Juan Quintela
2022-07-05 15:11 ` Juan Quintela
2022-07-05 16:52 ` Daniel P. Berrangé
2022-07-05 17:13 ` Dr. David Alan Gilbert
2022-07-05 17:16 ` Daniel P. Berrangé
2022-07-05 17:20 ` Dr. David Alan Gilbert
2022-07-28 8:25 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfmnderg.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=leobras@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.