Re: [PATCH v4 4/4] migration: Change zero_copy_send from migration parameter to migration capability

[Juan Quintela <quintela@redhat.com>]

Leonardo Bras <leobras@redhat.com> wrote:
> When originally implemented, zero_copy_send was designed as a Migration
> paramenter.
>
> But taking into account how is that supposed to work, and how
> the difference between a capability and a parameter, it only makes sense
> that zero-copy-send would work better as a capability.
>
> Taking into account how recently the change got merged, it was decided
> that it's still time to make it right, and convert zero_copy_send into
> a Migration capability.
>
> Signed-off-by: Leonardo Bras <leobras@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>


Note to myself: I would really love not to have to write so much
boilerplate code each time that we want to add a parameter/capability.

Adding the name, the documentation, and the check to set it up should be
all that be necesary.

A parameter needs to be defined twiced in qapi, 6 times in migration.c
and another one in hmp.  Capabilities are a better, but still room to improvement.

Later, Juan.