From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60912C433FE for ; Mon, 9 May 2022 09:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbiEIJav (ORCPT ); Mon, 9 May 2022 05:30:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237186AbiEIIzy (ORCPT ); Mon, 9 May 2022 04:55:54 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F17013F1E7; Mon, 9 May 2022 01:52:00 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1652086318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F47FNB3UPmZkk3XgxnsY0dE6OJ5OY97nItlGqfv1nig=; b=MUrIGsX15rb+saRCqWwo7fGrHKkoPeYHsfDkuifsddStxXPK7vpsFeXPM+uJpMeqTJfiX0 1wfvYcDEWGBYWqqS9x0s9UYuvpdoshqHwuPmU5LVr55f8b5tQdqSd7PhzQVd7JLteNO3Kp FZvdIIC4eE8GPD/RyItmNBom9EfEdBzWqZ/8FbxDmn3PRSy9tZD/10LWUQwVO199DbUjVA sGJhjPZheZFhX2UkM/V24VEiyCISV6tGDKc0/MzMrrUXEA8lD4rR1vwuUZK2ToZS4+FOMP 6gx92yX0NOydhaxgBz9mOjrjjTnasPwhFwIlo6ru1SJHYaZ2YEH2lPPrPhqaaA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1652086318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F47FNB3UPmZkk3XgxnsY0dE6OJ5OY97nItlGqfv1nig=; b=25QTTNR1gr/qNxOFt4KgxJmy+X+P9qgMg06xzXZUPudpM6mbF6bIcMMOloHobP2e4k15Ss /FpS5Oy7H07w/4BQ== To: Pali =?utf-8?Q?Roh=C3=A1r?= , Marc Zyngier Cc: Rob Herring , Bjorn Helgaas , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman Subject: Re: [PATCH 2/6] irqchip/armada-370-xp: Implement SoC Error interrupts In-Reply-To: <20220506185546.n5rl3chyyauy4bjt@pali> References: <20220506134029.21470-1-pali@kernel.org> <20220506134029.21470-3-pali@kernel.org> <87mtfu7ccd.wl-maz@kernel.org> <20220506183051.wimo7p4nuqfnl2aj@pali> <8735hmijlu.wl-maz@kernel.org> <20220506185546.n5rl3chyyauy4bjt@pali> Date: Mon, 09 May 2022 10:51:57 +0200 Message-ID: <87sfpjytoy.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Pali, On Fri, May 06 2022 at 20:55, Pali Roh=C3=A1r wrote: > On Friday 06 May 2022 19:47:25 Marc Zyngier wrote: >> > I'm not rewriting driver or doing big refactor of it, as this is not in >> > the scope of the PCIe AER interrupt support. >> >> Fair enough. By the same logic, I'm not taking any change to the >> driver until it is put in a better shape. Your call. > > If you are maintainer of this code then it is expected from _you_ to > move the current code into _better shape_ as you wrote and expect. And > then show us exactly, how new changes in this driver should look like, > in examples. this is not how kernel development works. Maintainers are not the servants who mop up the mess which random people dump into the tree. They are gatekeepers and one of their duties is to prevent that mess is created or existing mess is proliferated. You are asking the maintainer to take your changes, deal with the fallout and maintain them for a long time free of charge. So it's a very reasonable request from a maintainer to ask for refactoring of existing code before adding new functionality to it. With such a request the refactoring becomes scope of your work, whether you and your manager like it or not. If you don't want to do that extra work, then don't expect maintainers to care about your fancy new features. Marc gave you very reasonable and consice directions how the code should be reworked. He spent a lot of time explaining it to you. Again, free of charge. Now you expect him to do your homework free of charge, so you can get your feature merged? Nice try. Thanks, Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D040C433F5 for ; Mon, 9 May 2022 08:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zbp1+ndOaE0cNosyp1skfQ0hKCYOO75DHfto3vcdqiY=; b=cH71abR27E2cqk eba5YO+aVGtZ5A4G2umWhU/fKw0Z+sgky5KxYRPbInSKDj8uVNhicdejyQwckKaYAkgVBsWH1emVa jbF7egFr6hO3OrrmnF0Vku0B3zxXPMr24BRu8MX8CggAMI2U6cU/GPOXhp8NwV7eIx55/r8Uf8dqi z03KwOG1mw9mwLhdp5pQIMJWrtVsAgxCNFweHNWPBHHxQ6cwwPcIFi6h30XbDuA9qGwKOUC4N3Dwh D1P5jfHMk8QxpS7o0bOtHbQaD82Ij3SJRaYmaAb6kosDG/PhzzxkkFTvDbOCAsm4Nk3sVyhLEh4ed Ew2YDMikZlgyYeFeXzsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnz87-00DEbe-7a; Mon, 09 May 2022 08:52:35 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnz7f-00DEIh-QQ for linux-arm-kernel@lists.infradead.org; Mon, 09 May 2022 08:52:09 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1652086318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F47FNB3UPmZkk3XgxnsY0dE6OJ5OY97nItlGqfv1nig=; b=MUrIGsX15rb+saRCqWwo7fGrHKkoPeYHsfDkuifsddStxXPK7vpsFeXPM+uJpMeqTJfiX0 1wfvYcDEWGBYWqqS9x0s9UYuvpdoshqHwuPmU5LVr55f8b5tQdqSd7PhzQVd7JLteNO3Kp FZvdIIC4eE8GPD/RyItmNBom9EfEdBzWqZ/8FbxDmn3PRSy9tZD/10LWUQwVO199DbUjVA sGJhjPZheZFhX2UkM/V24VEiyCISV6tGDKc0/MzMrrUXEA8lD4rR1vwuUZK2ToZS4+FOMP 6gx92yX0NOydhaxgBz9mOjrjjTnasPwhFwIlo6ru1SJHYaZ2YEH2lPPrPhqaaA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1652086318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F47FNB3UPmZkk3XgxnsY0dE6OJ5OY97nItlGqfv1nig=; b=25QTTNR1gr/qNxOFt4KgxJmy+X+P9qgMg06xzXZUPudpM6mbF6bIcMMOloHobP2e4k15Ss /FpS5Oy7H07w/4BQ== To: Pali =?utf-8?Q?Roh=C3=A1r?= , Marc Zyngier Cc: Rob Herring , Bjorn Helgaas , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman Subject: Re: [PATCH 2/6] irqchip/armada-370-xp: Implement SoC Error interrupts In-Reply-To: <20220506185546.n5rl3chyyauy4bjt@pali> References: <20220506134029.21470-1-pali@kernel.org> <20220506134029.21470-3-pali@kernel.org> <87mtfu7ccd.wl-maz@kernel.org> <20220506183051.wimo7p4nuqfnl2aj@pali> <8735hmijlu.wl-maz@kernel.org> <20220506185546.n5rl3chyyauy4bjt@pali> Date: Mon, 09 May 2022 10:51:57 +0200 Message-ID: <87sfpjytoy.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_015208_024765_FA74F192 X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UGFsaSwKCk9uIEZyaSwgTWF5IDA2IDIwMjIgYXQgMjA6NTUsIFBhbGkgUm9ow6FyIHdyb3RlOgo+ IE9uIEZyaWRheSAwNiBNYXkgMjAyMiAxOTo0NzoyNSBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+ID4g SSdtIG5vdCByZXdyaXRpbmcgZHJpdmVyIG9yIGRvaW5nIGJpZyByZWZhY3RvciBvZiBpdCwgYXMg dGhpcyBpcyBub3QgaW4KPj4gPiB0aGUgc2NvcGUgb2YgdGhlIFBDSWUgQUVSIGludGVycnVwdCBz dXBwb3J0Lgo+Pgo+PiBGYWlyIGVub3VnaC4gQnkgdGhlIHNhbWUgbG9naWMsIEknbSBub3QgdGFr aW5nIGFueSBjaGFuZ2UgdG8gdGhlCj4+IGRyaXZlciB1bnRpbCBpdCBpcyBwdXQgaW4gYSBiZXR0 ZXIgc2hhcGUuIFlvdXIgY2FsbC4KPgo+IElmIHlvdSBhcmUgbWFpbnRhaW5lciBvZiB0aGlzIGNv ZGUgdGhlbiBpdCBpcyBleHBlY3RlZCBmcm9tIF95b3VfIHRvCj4gbW92ZSB0aGUgY3VycmVudCBj b2RlIGludG8gX2JldHRlciBzaGFwZV8gYXMgeW91IHdyb3RlIGFuZCBleHBlY3QuIEFuZAo+IHRo ZW4gc2hvdyB1cyBleGFjdGx5LCBob3cgbmV3IGNoYW5nZXMgaW4gdGhpcyBkcml2ZXIgc2hvdWxk IGxvb2sgbGlrZSwKPiBpbiBleGFtcGxlcy4KCnRoaXMgaXMgbm90IGhvdyBrZXJuZWwgZGV2ZWxv cG1lbnQgd29ya3MuCgpNYWludGFpbmVycyBhcmUgbm90IHRoZSBzZXJ2YW50cyB3aG8gbW9wIHVw IHRoZSBtZXNzIHdoaWNoIHJhbmRvbSBwZW9wbGUKZHVtcCBpbnRvIHRoZSB0cmVlLiBUaGV5IGFy ZSBnYXRla2VlcGVycyBhbmQgb25lIG9mIHRoZWlyIGR1dGllcyBpcyB0bwpwcmV2ZW50IHRoYXQg bWVzcyBpcyBjcmVhdGVkIG9yIGV4aXN0aW5nIG1lc3MgaXMgcHJvbGlmZXJhdGVkLgoKWW91IGFy ZSBhc2tpbmcgdGhlIG1haW50YWluZXIgdG8gdGFrZSB5b3VyIGNoYW5nZXMsIGRlYWwgd2l0aCB0 aGUKZmFsbG91dCBhbmQgbWFpbnRhaW4gdGhlbSBmb3IgYSBsb25nIHRpbWUgZnJlZSBvZiBjaGFy Z2UuIFNvIGl0J3MgYSB2ZXJ5CnJlYXNvbmFibGUgcmVxdWVzdCBmcm9tIGEgbWFpbnRhaW5lciB0 byBhc2sgZm9yIHJlZmFjdG9yaW5nIG9mIGV4aXN0aW5nCmNvZGUgYmVmb3JlIGFkZGluZyBuZXcg ZnVuY3Rpb25hbGl0eSB0byBpdC4KCldpdGggc3VjaCBhIHJlcXVlc3QgdGhlIHJlZmFjdG9yaW5n IGJlY29tZXMgc2NvcGUgb2YgeW91ciB3b3JrLCB3aGV0aGVyCnlvdSBhbmQgeW91ciBtYW5hZ2Vy IGxpa2UgaXQgb3Igbm90LiBJZiB5b3UgZG9uJ3Qgd2FudCB0byBkbyB0aGF0IGV4dHJhCndvcmss IHRoZW4gZG9uJ3QgZXhwZWN0IG1haW50YWluZXJzIHRvIGNhcmUgYWJvdXQgeW91ciBmYW5jeSBu ZXcKZmVhdHVyZXMuCgpNYXJjIGdhdmUgeW91IHZlcnkgcmVhc29uYWJsZSBhbmQgY29uc2ljZSBk aXJlY3Rpb25zIGhvdyB0aGUgY29kZSBzaG91bGQKYmUgcmV3b3JrZWQuIEhlIHNwZW50IGEgbG90 IG9mIHRpbWUgZXhwbGFpbmluZyBpdCB0byB5b3UuIEFnYWluLCBmcmVlIG9mCmNoYXJnZS4gTm93 IHlvdSBleHBlY3QgaGltIHRvIGRvIHlvdXIgaG9tZXdvcmsgZnJlZSBvZiBjaGFyZ2UsIHNvIHlv dQpjYW4gZ2V0IHlvdXIgZmVhdHVyZSBtZXJnZWQ/IE5pY2UgdHJ5LgoKVGhhbmtzLAoKICAgICAg ICBUaG9tYXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK