From: Jakub Sitnicki <jakub@cloudflare.com>
To: Wang Yufen <wangyufen@huawei.com>
Cc: ast@kernel.org, john.fastabend@gmail.com, daniel@iogearbox.net,
lmb@cloudflare.com, davem@davemloft.net, kafai@fb.com,
dsahern@kernel.org, kuba@kernel.org, songliubraving@fb.com,
yhs@fb.com, kpsingh@kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpf, sockmap: Manual deletion of sockmap elements in user mode is not allowed
Date: Mon, 14 Mar 2022 16:30:30 +0100 [thread overview]
Message-ID: <87sfrky2bt.fsf@cloudflare.com> (raw)
In-Reply-To: <20220314124432.3050394-1-wangyufen@huawei.com>
On Mon, Mar 14, 2022 at 08:44 PM +08, Wang Yufen wrote:
> A tcp socket in a sockmap. If user invokes bpf_map_delete_elem to delete
> the sockmap element, the tcp socket will switch to use the TCP protocol
> stack to send and receive packets. The switching process may cause some
> issues, such as if some msgs exist in the ingress queue and are cleared
> by sk_psock_drop(), the packets are lost, and the tcp data is abnormal.
>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
Can you please tell us a bit more about the life-cycle of the socket in
your workload? Questions that come to mind:
1) What triggers the removal of the socket from sockmap in your case?
2) Would it still be a problem if removal from sockmap did not cause any
packets to get dropped?
[...]
next prev parent reply other threads:[~2022-03-14 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 12:44 [PATCH bpf-next] bpf, sockmap: Manual deletion of sockmap elements in user mode is not allowed Wang Yufen
2022-03-14 15:30 ` Jakub Sitnicki [this message]
2022-03-15 7:24 ` wangyufen
2022-03-15 12:12 ` Jakub Sitnicki
2022-03-15 16:25 ` Daniel Borkmann
[not found] ` <f5a45e95-bac2-e1be-2d7b-5e6d55f9b408@huawei.com>
2022-03-16 5:23 ` John Fastabend
2022-03-16 14:57 ` Jakub Sitnicki
2022-03-16 0:36 ` Cong Wang
2022-03-16 3:25 ` wangyufen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfrky2bt.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=wangyufen@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.