From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 751E010E558 for ; Mon, 7 Feb 2022 12:31:15 +0000 (UTC) From: Jani Nikula In-Reply-To: <3af10091-6a1f-0d13-944f-7f7833837e1e@amd.com> References: <20220131142818.2686782-1-Rodrigo.Siqueira@amd.com> <20220131142818.2686782-2-Rodrigo.Siqueira@amd.com> <3af10091-6a1f-0d13-944f-7f7833837e1e@amd.com> Date: Mon, 07 Feb 2022 14:31:03 +0200 Message-ID: <87sfsurh88.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [igt-dev] [RFC i-g-t 1/1] MAINTAINERS: Introduce MAINTAINERS file List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Rodrigo Siqueira Jordao , Petri Latvala , Rodrigo Siqueira Cc: Qingqing Zhuo , igt-dev@lists.freedesktop.org, Solomon Chiu , Sean Paul , Bhawanpreet Lakha , Mark Yacoub List-ID: On Thu, 03 Feb 2022, Rodrigo Siqueira Jordao wrote: > On 2022-02-03 6:03 a.m., Petri Latvala wrote: >> On Mon, Jan 31, 2022 at 09:28:18AM -0500, Rodrigo Siqueira wrote: >>> IGT is growing in terms of new vendors actively using it. Right now, we >>> only have Intel CI to validate new patches, which can create a situation >>> where bugs get accidentally introduced to other vendors. To alleviate >>> this problem and also making easy for other developers to be aware of >>> some specific changes, I'm proposing the introduction of the MAINTAINERS >>> file as the one used in the Linux kernel. With this approach, we can >>> have multiple enginers from different companies as reviewers for >>> specific tests, and contributors should use get_maintainers script to >>> find the right people to address their changes. >>> >>> Cc: Arkadiusz Hiler >>> Cc: Petri Latvala >>> Cc: Mark Yacoub >>> Cc: Jessica Zhang >>> Cc: Abhinav Kumar >>> Cc: Melissa Wen >>> Cc: Sean Paul >>> Cc: Harry Wentland >>> Cc: Sun Peng Li(Leo) >>> Cc: Chao-kai Wang (Stylon) >>> Cc: Wayne Lin >>> Cc: Nicholas Choi >>> Cc: Martin Peres >>> Cc: Aurabindo Pillai >>> Cc: Bhawanpreet Lakha >>> Cc: Qingqing Zhuo (Lilian) >>> Cc: Solomon Chiu >>> Signed-off-by: Rodrigo Siqueira >> >> >> A tentative ack on this effort from me, for getting more contact >> points formally documented. >> >> As for the implementation of it, I know this is copied from the kernel >> so I know the reason why they're there, but reduce the useless >> complexity in the documentation comment like the type of version >> control in a subtree, and things that just aren't true for IGT, like >> asking for testing from 4 or 5 people. > > Hi Petri, > > Thanks for your feedback. I just copy-paste most parts of this kernel > MAINTAINERs file since this is just a prototype. I will prepare the > first version of this patch and submit it again; in this new version, I > will drop some part of the documentation which does not make sense for IGT. FWIW, if I were to do this, I'd do it in yaml and implement it in python+strictyaml with a schema. No need to import a monster perl parser from kernel or implement our own. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center