From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id F064010E578 for ; Thu, 6 Jan 2022 02:24:16 +0000 (UTC) Date: Wed, 05 Jan 2022 18:24:14 -0800 Message-ID: <87sfu1a9f5.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20220105064945.9640-3-zbigniew.kempczynski@intel.com> References: <20220105064945.9640-1-zbigniew.kempczynski@intel.com> <20220105064945.9640-3-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t 2/3] tests/i915/gem_softpin: Add safe-start test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org, Petri Latvala List-ID: On Tue, 04 Jan 2022 22:49:44 -0800, Zbigniew Kempczy=F1ski wrote: > > + offset1 =3D gem_detect_min_start_offset_for_region(i915, region1); > + offset2 =3D gem_detect_min_start_offset_for_region(i915, region2); > + alignment =3D gem_detect_safe_alignment(i915); > + igt_debug("safe alignment: %llx\n", (long long) alignment); > + igt_debug("safe start offset: %llx\n", > + (long long) gem_detect_safe_start_offset(i915)); > + igt_debug("minimum object1 start offset: %llx\n", (long long) offset1); > + igt_debug("minimum object2 start offset: %llx\n", (long long) offset2); Maybe also add print for the min_alignment value here? > + igt_describe("Check start offset and alignment detection"); > + igt_subtest("safe-start") > + safe_start(fd); I think "safe-start" is a really ambiguous name so we should change the name to something like "safe-align" or 'safe-offset", no? Otherwise this is: Reviewed-by: Ashutosh Dixit