From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] samples: bpf: avoid name collision with kernel enum values
Date: Mon, 27 Sep 2021 14:37:30 +0200 [thread overview]
Message-ID: <87sfxqjit1.fsf@toke.dk> (raw)
In-Reply-To: <20210926125605.1101605-1-memxor@gmail.com>
Kumar Kartikeya Dwivedi <memxor@gmail.com> writes:
> In xdp_redirect_map_multi.bpf.c, on newer kernels samples compilation
> fails when vmlinux.h is generated from a kernel supporting broadcast for
> devmap. Hence, avoid naming collisions to prevent build failure.
Hmm, shouldn't the sample just be getting the value from the kernel in
the first place instead of re-defining it?
-Toke
next prev parent reply other threads:[~2021-09-27 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 12:56 [PATCH bpf-next] samples: bpf: avoid name collision with kernel enum values Kumar Kartikeya Dwivedi
2021-09-27 12:37 ` Toke Høiland-Jørgensen [this message]
2021-09-27 13:46 ` Kumar Kartikeya Dwivedi
2021-09-27 16:01 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfxqjit1.fsf@toke.dk \
--to=toke@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.