From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE2CAC48BDF for ; Fri, 18 Jun 2021 05:53:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F3B9611CD for ; Fri, 18 Jun 2021 05:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232660AbhFRFzM (ORCPT ); Fri, 18 Jun 2021 01:55:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38428 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232622AbhFRFzK (ORCPT ); Fri, 18 Jun 2021 01:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623995581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pt7s6thOZ7bruleZlMytZjolyQHwvGo+oh9LKoATJaQ=; b=GNDWWUnaItN3xQhAMn66u9AipP6+Uki6r90IKXZ2dy1FWTBS142Sl0wvhbi/5sfWlCTakA v+snXo55L173dZPo8qJNuP+EDuSDopPMfoN1KByi3UiiuL/is4jhyOJ1WiX82qs/X/E2OR GF1ZyjO056pJmxmk5OYfDUY0wUOerkc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-z2giWGiJPCaVzEnRt1VuKQ-1; Fri, 18 Jun 2021 01:52:58 -0400 X-MC-Unique: z2giWGiJPCaVzEnRt1VuKQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 784128015DB; Fri, 18 Jun 2021 05:52:56 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-104.ams2.redhat.com [10.36.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A448116E4D; Fri, 18 Jun 2021 05:52:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3AC80113865F; Fri, 18 Jun 2021 07:52:47 +0200 (CEST) From: Markus Armbruster To: Eduardo Habkost Cc: Claudio Fontana , Laurent Vivier , Thomas Huth , Vladimir Sementsov-Ogievskiy , kvm@vger.kernel.org, Marcelo Tosatti , Richard Henderson , qemu-devel@nongnu.org, Valeriy Vdovin , Denis Lunev , Paolo Bonzini , Eric Blake Subject: Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action References: <20210603090753.11688-1-valeriy.vdovin@virtuozzo.com> <87im2d6p5v.fsf@dusky.pond.sub.org> <20210617074919.GA998232@dhcp-172-16-24-191.sw.ru> <87a6no3fzf.fsf@dusky.pond.sub.org> <790d22e1-5de9-ba20-6c03-415b62223d7d@suse.de> <877dis1sue.fsf@dusky.pond.sub.org> <20210617153949.GA357@dhcp-172-16-24-191.sw.ru> <20210617165111.eu3x2pvinpoedsqj@habkost.net> Date: Fri, 18 Jun 2021 07:52:47 +0200 In-Reply-To: <20210617165111.eu3x2pvinpoedsqj@habkost.net> (Eduardo Habkost's message of "Thu, 17 Jun 2021 12:51:11 -0400") Message-ID: <87sg1fwwgg.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Eduardo Habkost writes: > On Thu, Jun 17, 2021 at 05:53:11PM +0200, Claudio Fontana wrote: >> On 6/17/21 5:39 PM, Valeriy Vdovin wrote: >> > On Thu, Jun 17, 2021 at 04:14:17PM +0200, Markus Armbruster wrote: >> >> Claudio Fontana writes: >> >> >> >>> On 6/17/21 1:09 PM, Markus Armbruster wrote: [...] >> >>>> If it just isn't implemented for anything but KVM, then putting "kvm" >> >>>> into the command name is a bad idea. Also, the commit message should >> >>>> briefly note the restriction to KVM. >> >> >> >> Perhaps this one is closer to reality. >> >> >> > I agree. >> > What command name do you suggest? >> >> query-exposed-cpuid? > > Pasting the reply I sent at [1]: > > I don't really mind how the command is called, but I would prefer > to add a more complex abstraction only if maintainers of other > accelerators are interested and volunteer to provide similar > functionality. I don't want to introduce complexity for use > cases that may not even exist. > > I'm expecting this to be just a debugging mechanism, not a stable > API to be maintained and supported for decades. (Maybe a "x-" > prefix should be added to indicate that?) > > [1] https://lore.kernel.org/qemu-devel/20210602204604.crsxvqixkkll4ef4@habkost.net x-query-x86_64-cpuid? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BA19C48BDF for ; Fri, 18 Jun 2021 05:53:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 914D3611CD for ; Fri, 18 Jun 2021 05:53:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 914D3611CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lu7Rs-0006bU-EE for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 01:53:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lu7RD-0005vn-4V for qemu-devel@nongnu.org; Fri, 18 Jun 2021 01:53:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lu7R7-0007Ce-Vj for qemu-devel@nongnu.org; Fri, 18 Jun 2021 01:53:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623995579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pt7s6thOZ7bruleZlMytZjolyQHwvGo+oh9LKoATJaQ=; b=cOrohjj0/RAwQLpf5IOTnrGgTkxDr8vCFVNDJ2w5V5OPR6Lu1MlNtKHETKbzWdNSKEJG2m NMwK912twI4b1kda1apQTG0WyDJAwI+wpbcRZy3mnwdfOL3pKE2FPl3RgiR03FvPVI5EwM YQq6wz9OUeFN5jliZROjFR1QK+7fu6c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-z2giWGiJPCaVzEnRt1VuKQ-1; Fri, 18 Jun 2021 01:52:58 -0400 X-MC-Unique: z2giWGiJPCaVzEnRt1VuKQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 784128015DB; Fri, 18 Jun 2021 05:52:56 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-104.ams2.redhat.com [10.36.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A448116E4D; Fri, 18 Jun 2021 05:52:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3AC80113865F; Fri, 18 Jun 2021 07:52:47 +0200 (CEST) From: Markus Armbruster To: Eduardo Habkost Subject: Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action References: <20210603090753.11688-1-valeriy.vdovin@virtuozzo.com> <87im2d6p5v.fsf@dusky.pond.sub.org> <20210617074919.GA998232@dhcp-172-16-24-191.sw.ru> <87a6no3fzf.fsf@dusky.pond.sub.org> <790d22e1-5de9-ba20-6c03-415b62223d7d@suse.de> <877dis1sue.fsf@dusky.pond.sub.org> <20210617153949.GA357@dhcp-172-16-24-191.sw.ru> <20210617165111.eu3x2pvinpoedsqj@habkost.net> Date: Fri, 18 Jun 2021 07:52:47 +0200 In-Reply-To: <20210617165111.eu3x2pvinpoedsqj@habkost.net> (Eduardo Habkost's message of "Thu, 17 Jun 2021 12:51:11 -0400") Message-ID: <87sg1fwwgg.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.197, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Vladimir Sementsov-Ogievskiy , kvm@vger.kernel.org, Marcelo Tosatti , Richard Henderson , qemu-devel@nongnu.org, Claudio Fontana , Paolo Bonzini , Denis Lunev , Eric Blake , Valeriy Vdovin Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eduardo Habkost writes: > On Thu, Jun 17, 2021 at 05:53:11PM +0200, Claudio Fontana wrote: >> On 6/17/21 5:39 PM, Valeriy Vdovin wrote: >> > On Thu, Jun 17, 2021 at 04:14:17PM +0200, Markus Armbruster wrote: >> >> Claudio Fontana writes: >> >> >> >>> On 6/17/21 1:09 PM, Markus Armbruster wrote: [...] >> >>>> If it just isn't implemented for anything but KVM, then putting "kvm" >> >>>> into the command name is a bad idea. Also, the commit message should >> >>>> briefly note the restriction to KVM. >> >> >> >> Perhaps this one is closer to reality. >> >> >> > I agree. >> > What command name do you suggest? >> >> query-exposed-cpuid? > > Pasting the reply I sent at [1]: > > I don't really mind how the command is called, but I would prefer > to add a more complex abstraction only if maintainers of other > accelerators are interested and volunteer to provide similar > functionality. I don't want to introduce complexity for use > cases that may not even exist. > > I'm expecting this to be just a debugging mechanism, not a stable > API to be maintained and supported for decades. (Maybe a "x-" > prefix should be added to indicate that?) > > [1] https://lore.kernel.org/qemu-devel/20210602204604.crsxvqixkkll4ef4@habkost.net x-query-x86_64-cpuid?