From: Fabiano Rosas <farosas@linux.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, lucas.araujo@eldorado.org.br,
fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org,
"Bruno Larsen \(billionai\)" <bruno.larsen@eldorado.org.br>,
matheus.ferst@eldorado.org.br, luis.pires@eldorado.org.br
Subject: Re: [PATCH v3] target/ppc: code motion from translate_init.c.inc to gdbstub.c
Date: Mon, 26 Apr 2021 12:50:54 -0300 [thread overview]
Message-ID: <87sg3d2gf5.fsf@linux.ibm.com> (raw)
In-Reply-To: <YHkIHYx77a2XHMQN@yekko.fritz.box>
David Gibson <david@gibson.dropbear.id.au> writes:
> On Wed, Apr 14, 2021 at 01:09:19PM -0700, Richard Henderson wrote:
>> On 4/14/21 7:59 AM, Bruno Larsen (billionai) wrote:
>> > All the code related to gdb has been moved from translate_init.c.inc
>> > file to the gdbstub.c file, where it makes more sense.
>> >
>> > This new version puts the prototypes in internal.h, to not expose
>> > them unnecessarily.
>> >
>> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
>> > Suggested-by: Fabiano Rosas <farosas@linux.ibm.com>
>> > ---
>> > target/ppc/gdbstub.c | 258 ++++++++++++++++++++++++++++++++
>> > target/ppc/internal.h | 5 +
>> > target/ppc/translate_init.c.inc | 254 +------------------------------
>> > 3 files changed, 264 insertions(+), 253 deletions(-)
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> Applied to ppc-for-6.1, thanks.
The prototypes moved to internal.h in v3 so gdbstub.c needs to include
it now. The linux-user build is breaking with:
$ ../configure --target-list=ppc64le-linux-user
$ make -j$(nproc)
(...)
[316/959] Compiling C object libqemu-ppc64le-linux-user.fa.p/target_ppc_gdbstub.c.o
FAILED: libqemu-ppc64le-linux-user.fa.p/target_ppc_gdbstub.c.o
cc -Ilibqemu-ppc64le-linux-user.fa.p -I. -I.. -Itarget/ppc -I../target/ppc -I../linux-user/host/x86_64 -Ilinux-user -I../linux-user -Ilinux-user/ppc -I../linux-user/ppc -I../capstone/include/capstone -Itrace -Iqap
i -Iui/shader -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -Werror -std=gnu99 -O2 -g -isystem /home/fabiano/kvm/qemu-patch-testing/linux-headers -isystem
linux-headers -iquote . -iquote /home/fabiano/kvm/qemu-patch-testing -iquote /home/fabiano/kvm/qemu-patch-testing/include -iquote /home/fabiano/kvm/qemu-patch-testing/disas/libvixl -iquote /home/fabiano/kvm/qemu-
patch-testing/tcg/i386 -iquote /home/fabiano/kvm/qemu-patch-testing/accel/tcg -pthread -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes
-Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wig
nored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIC -isystem.
./linux-headers -isystemlinux-headers -DNEED_CPU_H '-DCONFIG_TARGET="ppc64le-linux-user-config-target.h"' '-DCONFIG_DEVICES="ppc64le-linux-user-config-devices.h"' -MD -MQ libqemu-ppc64le-linux-user.fa.p/target_ppc
_gdbstub.c.o -MF libqemu-ppc64le-linux-user.fa.p/target_ppc_gdbstub.c.o.d -o libqemu-ppc64le-linux-user.fa.p/target_ppc_gdbstub.c.o -c ../target/ppc/gdbstub.c
../target/ppc/gdbstub.c:615:8: error: no previous prototype for ‘ppc_gdb_arch_name’ [-Werror=missing-prototypes]
615 | gchar *ppc_gdb_arch_name(CPUState *cs)
| ^~~~~~~~~~~~~~~~~
../target/ppc/gdbstub.c:624:6: error: no previous prototype for ‘ppc_gdb_init’ [-Werror=missing-prototypes]
624 | void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *pcc)
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
>> > +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *pcc)
>> > +{
>> > +
>> > + if (pcc->insns_flags & PPC_FLOAT) {
>>
>> Watch the extra blank lines.
>
> Fixed in my tree.
next prev parent reply other threads:[~2021-04-26 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 14:59 [PATCH v3] target/ppc: code motion from translate_init.c.inc to gdbstub.c Bruno Larsen (billionai)
2021-04-14 20:09 ` Richard Henderson
2021-04-16 3:44 ` David Gibson
2021-04-26 15:50 ` Fabiano Rosas [this message]
2021-04-27 1:52 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg3d2gf5.fsf@linux.ibm.com \
--to=farosas@linux.ibm.com \
--cc=bruno.larsen@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.