All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/perl: fix configure when BR2_VERSION_FULL contains a '/'
Date: Wed, 31 Mar 2021 08:14:48 +0200	[thread overview]
Message-ID: <87sg4bc0iv.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210327224220.961977-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sat, 27 Mar 2021 23:42:20 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > When BR2_VERSION_FULL contains one or more '/', injection our version
 > in the perl patch-level fails:

 >     /usr/bin/sed: -e expression #1, char 27: unknown option to `s'

 > When the build is done in a git tree, and HEAD is a tag, BR2_VERSION_FULL
 > will contain that tag name. Even if not widely common, it is not unusual
 > for a tag to contain a '/', and this is perfectly legit in git.

 > So, mangle BR2_VERSION_FULL to escape all '/' with a backslash '\', so
 > that the sed expression is correct, and so that we eventually have a
 > correct pathclevel string in perl's --version output.

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Cc: Francois Perrad <francois.perrad@gadz.org>

Committed to 2020.02.x, 2020.11.x and 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2021-03-31  6:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 22:42 [Buildroot] [PATCH] package/perl: fix configure when BR2_VERSION_FULL contains a '/' Yann E. MORIN
2021-03-28 19:24 ` Thomas Petazzoni
2021-03-31  6:14 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg4bc0iv.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.