From: Alyssa Ross <hi@alyssa.is>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Subject: vhost-user protocol feature negotiation
Date: Wed, 05 Aug 2020 15:13:06 +0000 [thread overview]
Message-ID: <87sgd1ktx9.fsf@alyssa.is> (raw)
Quoting from the definition of VHOST_USER_SET_PROTOCOL_FEATURES in
vhost-user.rst:
> Only legal if feature bit ``VHOST_USER_F_PROTOCOL_FEATURES`` is present in
> ``VHOST_USER_GET_FEATURES``.
>
> .. Note::
> Slave that reported ``VHOST_USER_F_PROTOCOL_FEATURES`` must support
> this message even before ``VHOST_USER_SET_FEATURES`` was called.
To me, this could mean either of two things:
(1) If VHOST_USER_F_PROTOCOL_FEATURES hasn't been set, upon receiving
VHOST_USER_SET_PROTOCOL_FEATURES, a backend should enable the
protocol features immediately.
(2) If VHOST_USER_F_PROTOCOL_FEATURES hasn't been set, upon receiving
VHOST_USER_SET_PROTOCOL_FEATURES, a backend should store those
feature bits, but not actually consider them to be enabled until
after VHOST_USER_SET_FEATURES has been received (presumably
containing VHOST_USER_F_PROTOCOL_FEATURES).
The reason I bring this up is that QEMU appears to interpret it as (1),
while the vhost-user-net backend in Intel's cloud-hypervisor[1]
interprets it as (2). So I'm looking for a clarification.
[1]: https://github.com/cloud-hypervisor/cloud-hypervisor
Thanks in advance.
next reply other threads:[~2020-08-05 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 15:13 Alyssa Ross [this message]
2020-08-05 22:26 ` vhost-user protocol feature negotiation Michael S. Tsirkin
2020-08-06 8:59 ` Alyssa Ross
2020-08-06 9:49 ` Michael S. Tsirkin
2020-08-06 11:24 ` Alyssa Ross
2020-08-06 12:35 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgd1ktx9.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.