From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jarLj-0005du-Ji for mharc-grub-devel@gnu.org; Mon, 18 May 2020 21:47:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jarLh-0005cD-PN for grub-devel@gnu.org; Mon, 18 May 2020 21:47:17 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:40443) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jarLg-0002bE-T3 for grub-devel@gnu.org; Mon, 18 May 2020 21:47:17 -0400 Received: by mail-pf1-x441.google.com with SMTP id x2so5796644pfx.7 for ; Mon, 18 May 2020 18:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=809TVSJdMCPRRScTvaDkBmZ+rbBE1V+xUtW8qSl1ghs=; b=rbmlo8OOU6FjngbN1lGaq0kbFQaurxr343Ai4e2M10rGzhh6eaVT/V0APc5T5n0TE7 6HelkUU/ANUOib7Tgiyb8x3NgtDheOztnrDts6GnLe7O2PIwL1BqeFUE4jrCsq2GMCMa 8HoSIGmKDQkdffHcRVRgI9nCg8zISo3UogVuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=809TVSJdMCPRRScTvaDkBmZ+rbBE1V+xUtW8qSl1ghs=; b=Jw//ywSRls9L/Zu53oFHsBgSlGT32KbrAZTrnwhLbXGV7w5ZIXivQHfgissy/sBb3x rk+kqUXUOtynm+57VI/wvsbVcQIP7cjt6v+V8KmhDCaEy3U9EsDuPr7XE6FYtvCIDpLE 51Qug/FAe8ASzSoEyYG+7GGbuKPxwWN2uM8vqlmmpT9Nkernkma6/sJHaHy5WQScgtE5 wW/4lQYj4brJBK6Ef5NlxgPZFBmiG2lbgWtCta0wzGI8eE1ohJuxMqBLVGCLMiLPJ3xZ xrQbu6/MlDIk5VG09iAePo/82FVG3IBNbfCPtU17ovJtIkUpW7/JSOAcK7/kc+mz+wGm S3lA== X-Gm-Message-State: AOAM530OHTlgRtCzzFAu49Q/qT2aCW9c6XzXOWCcv3QhgFJmnd/bZnOB KVsJX+wYAq1SrisPE95u2y5GEA== X-Google-Smtp-Source: ABdhPJw0c1KVt5I6r7VYqv9mVJNW1QUl8J8QFudJgotw7F+2+o7ua5P9KQCLeN8YvWsjL1h3mXbCOQ== X-Received: by 2002:aa7:9a96:: with SMTP id w22mr20509498pfi.199.1589852834866; Mon, 18 May 2020 18:47:14 -0700 (PDT) Received: from localhost (2001-44b8-1113-6700-6801-5cbb-a4bb-6735.static.ipv6.internode.on.net. [2001:44b8:1113:6700:6801:5cbb:a4bb:6735]) by smtp.gmail.com with ESMTPSA id t21sm8617869pgu.39.2020.05.18.18.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 18:47:13 -0700 (PDT) From: Daniel Axtens To: Javier Martinez Canillas , Daniel Kiper Cc: grub-devel@gnu.org, eschwartz@archlinux.org, floppym@gentoo.org, glaubitz@physik.fu-berlin.de, leif@nuviainc.com, olaf@aepfle.de, phcoder@gmail.com, pjones@redhat.com, ps@pks.im Subject: Re: [PATCH v3 2/5] configure: Set gnu99 C language standard by default In-Reply-To: References: <20200513120251.9861-1-daniel.kiper@oracle.com> <20200513120251.9861-3-daniel.kiper@oracle.com> <87v9kyq7tj.fsf@dja-thinkpad.axtens.net> <20200518154952.snfclj26ibmbbkk3@tomti.i.net-space.pl> Date: Tue, 19 May 2020 11:47:10 +1000 Message-ID: <87sgfwr90h.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::441; envelope-from=dja@axtens.net; helo=mail-pf1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 01:47:18 -0000 Javier Martinez Canillas writes: > Hello Daniel, > > On 5/18/20 5:49 PM, Daniel Kiper wrote: > > [snip] > >>> >>> Without this patch, clang-9 fails on the use of nested functions in >>> commit cb2f15c54489 ("normal/main: Search for specific config files for >>> netboot") - I'll send a fix for that shortly. If I revert that as a >>> temporary measure, clang will build. >> >> Javier, could you take a look at this too? Javier, I think this is as simple as un-nesting the function, but you know the code base better than me, so I'll leave it to you unless you particularly want me to handle it. Regards, Daniel >> > > Sure, I'll take a look to this. > > Best regards, > -- > Javier Martinez Canillas > Software Engineer - Desktop Hardware Enablement > Red Hat