From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA67BC28CBC for ; Sat, 9 May 2020 10:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B80D820731 for ; Sat, 9 May 2020 10:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727827AbgEIKHJ (ORCPT ); Sat, 9 May 2020 06:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726012AbgEIKHI (ORCPT ); Sat, 9 May 2020 06:07:08 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 643D6C061A0C for ; Sat, 9 May 2020 03:07:08 -0700 (PDT) Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jXMNJ-0005Q1-AH; Sat, 09 May 2020 12:06:29 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 247B1100C8A; Sat, 9 May 2020 12:06:28 +0200 (CEST) From: Thomas Gleixner To: Andy Lutomirski Cc: LKML , X86 ML , "Paul E. McKenney" , Andy Lutomirski , Alexandre Chartre , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , Steven Rostedt , Joel Fernandes , Boris Ostrovsky , Juergen Gross , Brian Gerst , Mathieu Desnoyers , Josh Poimboeuf , Will Deacon , "Peter Zijlstra \(Intel\)" Subject: Re: [patch V4 part 2 12/18] x86,objtool: Make entry_64_compat.S objtool clean In-Reply-To: References: <20200505134112.272268764@linutronix.de> <20200505134341.272248024@linutronix.de> Date: Sat, 09 May 2020 12:06:28 +0200 Message-ID: <87sgg94e3f.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Lutomirski writes: > On Tue, May 5, 2020 at 7:14 AM Thomas Gleixner wrote: >> >> Currently entry_64_compat is exempt from objtool, but with vmlinux >> mode there is no hiding it. >> >> Make the following changes to make it pass: >> >> - change entry_SYSENTER_compat to STT_NOTYPE; it's not a function >> and doesn't have function type stack setup. >> >> - mark all STT_NOTYPE symbols with UNWIND_HINT_EMPTY; so we do >> validate them and don't treat them as unreachable. >> >> - don't abuse RSP as a temp register, this confuses objtool >> mightily as it (rightfully) thinks we're doing unspeakable >> things to the stack. >> > > Acked-by: Andy Lutomirski > >> Signed-off-by: Peter Zijlstra (Intel) > > Did a From line get eaten? Yes. A couple of patches which were just handed back and forth between me and Peter lost them. Fixed them all up localy already. Thanks, tglx