From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabiano Rosas Date: Wed, 25 Mar 2020 13:24:20 +0000 Subject: Re: [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call Message-Id: <87sghwh8jf.fsf@linux.ibm.com> List-Id: References: <20200324201211.1055236-1-farosas@linux.ibm.com> <87zhc4wxy9.fsf@mpe.ellerman.id.au> In-Reply-To: <87zhc4wxy9.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Michael Ellerman , linuxppc-dev@lists.ozlabs.org Cc: linuxram@us.ibm.com, paulus@samba.org, kvm-ppc@vger.kernel.org Michael Ellerman writes: > Fabiano Rosas writes: > >> QEMU can now print the ibm,os-term message[1], so let's include it in >> the RTAS call. E.g.: >> >> qemu-system-ppc64: OS terminated: Switch to secure mode failed. >> >> 1- https://git.qemu.org/?p=3Dqemu.git;a=3Dcommitdiff;h=A4c3791ae0 >> >> Signed-off-by: Fabiano Rosas >> --- >> arch/powerpc/kernel/prom_init.c | 3 +++ >> 1 file changed, 3 insertions(+) > > I have this queued: > https://patchwork.ozlabs.org/patch/1253390/ > > Which I think does the same thing? > Ah, all good then. Nothing to see here... =3D) > cheers > >> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_= init.c >> index 577345382b23..d543fb6d29c5 100644 >> --- a/arch/powerpc/kernel/prom_init.c >> +++ b/arch/powerpc/kernel/prom_init.c >> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str) >> if (token =3D 0) >> prom_panic("Could not get token for ibm,os-term\n"); >> os_term_args.token =3D cpu_to_be32(token); >> + os_term_args.nargs =3D cpu_to_be32(1); >> + os_term_args.args[0] =3D cpu_to_be32(__pa(str)); >> + >> prom_rtas_hcall((uint64_t)&os_term_args); >> } >> #endif /* CONFIG_PPC_SVM */ >> --=20 >> 2.23.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20558C1975A for ; Wed, 25 Mar 2020 13:32:37 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7C7B2076A for ; Wed, 25 Mar 2020 13:32:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7C7B2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48nTZB2KLBzDqkL for ; Thu, 26 Mar 2020 00:32:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=farosas@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48nTNw40w9zDqgP for ; Thu, 26 Mar 2020 00:24:32 +1100 (AEDT) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02PDILAN107496; Wed, 25 Mar 2020 09:24:26 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ywd8ef53x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Mar 2020 09:24:25 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 02PDDKbS006813; Wed, 25 Mar 2020 13:24:24 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma04wdc.us.ibm.com with ESMTP id 2ywaw91h42-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Mar 2020 13:24:24 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02PDOODD45416940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Mar 2020 13:24:24 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 62EF1AE062; Wed, 25 Mar 2020 13:24:24 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4256DAE060; Wed, 25 Mar 2020 13:24:23 +0000 (GMT) Received: from localhost (unknown [9.85.139.123]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS; Wed, 25 Mar 2020 13:24:22 +0000 (GMT) From: Fabiano Rosas To: Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term RTAS call In-Reply-To: <87zhc4wxy9.fsf@mpe.ellerman.id.au> References: <20200324201211.1055236-1-farosas@linux.ibm.com> <87zhc4wxy9.fsf@mpe.ellerman.id.au> Date: Wed, 25 Mar 2020 10:24:20 -0300 Message-ID: <87sghwh8jf.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-25_05:2020-03-24, 2020-03-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003250110 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxram@us.ibm.com, paulus@samba.org, kvm-ppc@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Michael Ellerman writes: > Fabiano Rosas writes: > >> QEMU can now print the ibm,os-term message[1], so let's include it in >> the RTAS call. E.g.: >> >> qemu-system-ppc64: OS terminated: Switch to secure mode failed. >> >> 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4c3791ae0 >> >> Signed-off-by: Fabiano Rosas >> --- >> arch/powerpc/kernel/prom_init.c | 3 +++ >> 1 file changed, 3 insertions(+) > > I have this queued: > https://patchwork.ozlabs.org/patch/1253390/ > > Which I think does the same thing? > Ah, all good then. Nothing to see here... =) > cheers > >> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c >> index 577345382b23..d543fb6d29c5 100644 >> --- a/arch/powerpc/kernel/prom_init.c >> +++ b/arch/powerpc/kernel/prom_init.c >> @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str) >> if (token == 0) >> prom_panic("Could not get token for ibm,os-term\n"); >> os_term_args.token = cpu_to_be32(token); >> + os_term_args.nargs = cpu_to_be32(1); >> + os_term_args.args[0] = cpu_to_be32(__pa(str)); >> + >> prom_rtas_hcall((uint64_t)&os_term_args); >> } >> #endif /* CONFIG_PPC_SVM */ >> -- >> 2.23.0