From: John Ogness <john.ogness@linutronix.de>
To: Eugeniu Rosca <erosca@de.adit-jv.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
Dirk Behme <dirk.behme@de.bosch.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [RFC PATCH 0/3] Fix quiet console in pre-panic scenarios
Date: Wed, 18 Mar 2020 16:40:27 +0100 [thread overview]
Message-ID: <87sgi5n02c.fsf@linutronix.de> (raw)
In-Reply-To: <20200318145600.GA20301@lxhi-065.adit-jv.com> (Eugeniu Rosca's message of "Wed, 18 Mar 2020 15:56:00 +0100")
On 2020-03-18, Eugeniu Rosca <erosca@de.adit-jv.com> wrote:
> On Mon, Mar 16, 2020 at 08:09:48PM +0100, Sebastian Andrzej Siewior wrote:
>> On 2020-03-16 14:35:17 [-0400], Steven Rostedt wrote:
>> > I don't see any issues with this patch set. What do others think?
>> >
>> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>> >
>> > [ Note, I only acked, and did not give a deep review of it ]
>>
>> What is the state of the other larger printk rework? If this does not
>> solve any -stable related issues then it will be replaced?
>
> Is this a question to John and his most recent series in
> https://lore.kernel.org/lkml/20200128161948.8524-1-john.ogness@linutronix.de/
> ?
>
> Is there any upstream agreement to already keep the current printk
> mechanism away from any updates?
No. Fixes are welcome!
The only thing we are trying to avoid at this stage is massive
refactoring/cleanup work. Your series does not fit into that category.
As to my opinion on this series, assuming it is acceptable for the
maintainers, I would like to see console_verbose() become an alias to
console_verbose_start(). Then @ignore_loglevel would be used for both
and CONSOLE_LOGLEVEL_MOTORMOUTH could be removed.
John Ogness
prev parent reply other threads:[~2020-03-18 15:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 17:09 [RFC PATCH 0/3] Fix quiet console in pre-panic scenarios Eugeniu Rosca
2020-03-15 17:09 ` [RFC PATCH 1/3] printk: convert ignore_loglevel to atomic_t Eugeniu Rosca
2020-03-15 17:09 ` [RFC PATCH 2/3] printk: add console_verbose_{start,end} Eugeniu Rosca
2020-03-16 21:19 ` [RFC PATCH 2/3] printk: add console_verbose_{start, end} kbuild test robot
2020-03-16 21:30 ` kbuild test robot
2020-03-18 16:00 ` [RFC PATCH 2/3] printk: add console_verbose_{start,end} John Ogness
2020-03-15 17:09 ` [RFC PATCH 3/3] watchdog: Turn console verbosity on when reporting softlockup Eugeniu Rosca
2020-03-17 2:18 ` Sergey Senozhatsky
2020-03-18 18:05 ` Eugeniu Rosca
2020-03-19 6:48 ` Sergey Senozhatsky
2020-03-19 7:38 ` Valdis Klētnieks
2020-03-19 8:01 ` Sergey Senozhatsky
2020-03-19 8:18 ` Valdis Klētnieks
2020-05-19 14:43 ` Petr Mladek
2020-03-19 8:20 ` John Ogness
2020-03-16 18:35 ` [RFC PATCH 0/3] Fix quiet console in pre-panic scenarios Steven Rostedt
2020-03-16 19:09 ` Sebastian Andrzej Siewior
2020-03-18 14:56 ` Eugeniu Rosca
2020-03-18 15:40 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgi5n02c.fsf@linutronix.de \
--to=john.ogness@linutronix.de \
--cc=Jisheng.Zhang@synaptics.com \
--cc=andrew_gabbasov@mentor.com \
--cc=bigeasy@linutronix.de \
--cc=dirk.behme@de.bosch.com \
--cc=erosca@de.adit-jv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=roscaeugeniu@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.