From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, linmiaohe <linmiaohe@huawei.com>
Cc: "rkrcmar\@redhat.com" <rkrcmar@redhat.com>,
"sean.j.christopherson\@intel.com"
<sean.j.christopherson@intel.com>,
"jmattson\@google.com" <jmattson@google.com>,
"joro\@8bytes.org" <joro@8bytes.org>,
"tglx\@linutronix.de" <tglx@linutronix.de>,
"mingo\@redhat.com" <mingo@redhat.com>,
"bp\@alien8.de" <bp@alien8.de>, "hpa\@zytor.com" <hpa@zytor.com>,
"kvm\@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86\@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] KVM: VMX: Use wrapper macro ~RMODE_GUEST_OWNED_EFLAGS_BITS directly
Date: Fri, 06 Mar 2020 10:44:53 +0100 [thread overview]
Message-ID: <87sgiles16.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <1e3f7ff0-0159-98e8-ba21-8806c3a14820@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 06/03/20 03:17, linmiaohe wrote:
>> Define a macro RMODE_HOST_OWNED_EFLAGS_BITS for (X86_EFLAGS_IOPL |
>> X86_EFLAGS_VM) as suggested by Vitaly seems a good way to fix this ?
>> Thanks.
>
> No, what if a host-owned flag was zero? I'd just leave it as is.
>
I'm not saying my suggestion was a good idea but honestly I'm failing to
wrap my head around this. The suggested 'RMODE_HOST_OWNED_EFLAGS_BITS'
would just be a define for (X86_EFLAGS_IOPL | X86_EFLAGS_VM) so
technically the patch would just be nop, no?
--
Vitaly
next prev parent reply other threads:[~2020-03-06 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 2:17 [PATCH] KVM: VMX: Use wrapper macro ~RMODE_GUEST_OWNED_EFLAGS_BITS directly linmiaohe
2020-03-06 5:32 ` Paolo Bonzini
2020-03-06 9:44 ` Vitaly Kuznetsov [this message]
2020-03-06 10:00 ` Paolo Bonzini
2020-03-06 10:15 ` Vitaly Kuznetsov
-- strict thread matches above, loose matches on Subject: below --
2020-03-06 2:11 linmiaohe
2020-03-05 2:35 linmiaohe
2020-03-05 10:08 ` Vitaly Kuznetsov
2020-03-05 11:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgiles16.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.