From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4DDC3F2D7 for ; Thu, 5 Mar 2020 12:25:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE1F220717 for ; Thu, 5 Mar 2020 12:25:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="bGejFpEd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE1F220717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48Y91Z51Z1zDqbh for ; Thu, 5 Mar 2020 23:25:06 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48Y8yx0WMGzDqjj for ; Thu, 5 Mar 2020 23:22:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=bGejFpEd; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 48Y8yv6fsmz9sRR; Thu, 5 Mar 2020 23:22:47 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1583410968; bh=+OsquJtq3grVp9YA4QqA6DFjcAjE+NTDtO/i5VDINiA=; h=From:To:Subject:In-Reply-To:References:Date:From; b=bGejFpEdUnYmJaCxy2Xd4CK00nKq8huiP4Gh2AmlGmXnNUbfKB+ZofUsg6ReKLW87 zURP281v2rkDPyR0I2i4hJg8SK5SwI2/ygRmLGQ6vRueCbvChZ/g8yj+Ehe9D16mOW ZUkvom/vfya9W18i4KjbnLfb/2SkmImrEwheB0jgm9kLeGrbExXXi/3kuYJ+ky8aQz 8JJY0nV2fIqMlFvW+hrmW50gob9YWQrA/3TTcefEBaMnPFTjTRSMXLpZml8C/5zMok r/Av7X3Dc7jBi9o00WX4SucGKSHOGNfVlQ2QndrK8gw4muj6CVwZpLCSLc1AVJfrNe E5Kq7bmvJLUvg== From: Michael Ellerman To: bugzilla-daemon@bugzilla.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [Bug 206695] New: kmemleak reports leaks in drivers/macintosh/windfarm In-Reply-To: References: Date: Thu, 05 Mar 2020 23:22:41 +1100 Message-ID: <87sginousu.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Can you try this patch? diff --git a/drivers/macintosh/windfarm_pm112.c b/drivers/macintosh/windfarm_pm112.c index 4150301a89a5..a16f43a1def9 100644 --- a/drivers/macintosh/windfarm_pm112.c +++ b/drivers/macintosh/windfarm_pm112.c @@ -125,7 +125,7 @@ static int create_cpu_loop(int cpu) { int chip = cpu / 2; int core = cpu & 1; - struct smu_sdbp_header *hdr; + struct smu_sdbp_header *hdr, *hdr2; struct smu_sdbp_cpupiddata *piddata; struct wf_cpu_pid_param pid; struct wf_control *main_fan = cpu_fans[0]; @@ -141,9 +141,9 @@ static int create_cpu_loop(int cpu) piddata = (struct smu_sdbp_cpupiddata *)&hdr[1]; /* Get FVT params to get Tmax; if not found, assume default */ - hdr = smu_sat_get_sdb_partition(chip, 0xC4 + core, NULL); - if (hdr) { - struct smu_sdbp_fvt *fvt = (struct smu_sdbp_fvt *)&hdr[1]; + hdr2 = smu_sat_get_sdb_partition(chip, 0xC4 + core, NULL); + if (hdr2) { + struct smu_sdbp_fvt *fvt = (struct smu_sdbp_fvt *)&hdr2[1]; tmax = fvt->maxtemp << 16; } else tmax = 95 << 16; /* default to 95 degrees C */ @@ -174,6 +174,10 @@ static int create_cpu_loop(int cpu) pid.min = fmin; wf_cpu_pid_init(&cpu_pid[cpu], &pid); + + kfree(hdr); + kfree(hdr2); + return 0; }