From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49E9C35671 for ; Sat, 22 Feb 2020 08:24:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A65EC20707 for ; Sat, 22 Feb 2020 08:24:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ibknjp5y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A65EC20707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j5Q57-00048l-PY; Sat, 22 Feb 2020 08:24:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j5Q56-00048e-CD for xen-devel@lists.xenproject.org; Sat, 22 Feb 2020 08:24:12 +0000 X-Inumbo-ID: b3466695-554c-11ea-87db-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [207.211.31.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id b3466695-554c-11ea-87db-12813bfff9fa; Sat, 22 Feb 2020 08:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582359851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T45vrP9XIhTb9vS7RjFPPl1JpkYIOutb0fUu3RFTTrw=; b=Ibknjp5yCD9t8t8M1bLmQSxRwMfGL24Jt/+owGZ9h5EqoQ24qkat4Tr6Rwln85defxydlu ffKxfpWGYsQ6H0UTCWxUjW5DqwfcGv5Khgun91oUtol/h82gp9FTvZvjEHzEvN0UWOJONJ IftnMcfhyMG6bv0kjqgqkg2xesXmQ40= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-52XP2uA5M1qKR3W2VghM7A-1; Sat, 22 Feb 2020 03:24:09 -0500 X-MC-Unique: 52XP2uA5M1qKR3W2VghM7A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4A4C189F760; Sat, 22 Feb 2020 08:24:07 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F176391; Sat, 22 Feb 2020 08:24:01 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A616511386A6; Sat, 22 Feb 2020 09:23:59 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy References: <20200131130118.1716-1-vsementsov@virtuozzo.com> <20200131130118.1716-2-vsementsov@virtuozzo.com> <87d0a88k6d.fsf@dusky.pond.sub.org> <7856fcbb-8c01-aba3-a11b-63058c117362@virtuozzo.com> <875zfz6gsh.fsf@dusky.pond.sub.org> <064ca8e9-458e-c780-92a0-05f40cf0975b@virtuozzo.com> Date: Sat, 22 Feb 2020 09:23:59 +0100 In-Reply-To: <064ca8e9-458e-c780-92a0-05f40cf0975b@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Fri, 21 Feb 2020 20:31:55 +0300") Message-ID: <87sgj31140.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, Paul Durrant , qemu-devel@nongnu.org, Laszlo Ersek , Markus Armbruster , Michael Roth , Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPiB3 cml0ZXM6Cgo+IDIxLjAyLjIwMjAgMTk6MzQsIE1hcmt1cyBBcm1icnVzdGVyIHdyb3RlOgo+PiBW bGFkaW1pciBTZW1lbnRzb3YtT2dpZXZza2l5IDx2c2VtZW50c292QHZpcnR1b3p6by5jb20+IHdy aXRlczoKPj4KPj4+IDIxLjAyLjIwMjAgMTA6MzgsIE1hcmt1cyBBcm1icnVzdGVyIHdyb3RlOgo+ Pj4+IFZsYWRpbWlyIFNlbWVudHNvdi1PZ2lldnNraXkgPHZzZW1lbnRzb3ZAdmlydHVvenpvLmNv bT4gd3JpdGVzOgo+Pj4+Cj4+Pj4+IEFkZCBmdW5jdGlvbnMgdG8gY2xlYW4gRXJyb3IgKiplcnJw OiBjYWxsIGNvcnJlc3BvbmRpbmcgRXJyb3IgKmVycgo+Pj4+PiBjbGVhbmluZyBmdW5jdGlvbiBh biBzZXQgcG9pbnRlciB0byBOVUxMLgo+Pj4+Pgo+Pj4+PiBOZXcgZnVuY3Rpb25zOgo+Pj4+PiAg ICAgZXJyb3JfZnJlZV9lcnJwCj4+Pj4+ICAgICBlcnJvcl9yZXBvcnRfZXJycAo+Pj4+PiAgICAg d2Fybl9yZXBvcnRfZXJycAo+Pj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBWbGFkaW1pciBTZW1l bnRzb3YtT2dpZXZza2l5IDx2c2VtZW50c292QHZpcnR1b3p6by5jb20+Cj4+Pj4+IFJldmlld2Vk LWJ5OiBHcmVnIEt1cnogPGdyb3VnQGthb2Qub3JnPgo+Pj4+PiBSZXZpZXdlZC1ieTogRXJpYyBC bGFrZSA8ZWJsYWtlQHJlZGhhdC5jb20+Cj4+Pj4+IC0tLQo+Pj4+Pgo+Pj4+PiBDQzogRXJpYyBC bGFrZSA8ZWJsYWtlQHJlZGhhdC5jb20+Cj4+Pj4+IENDOiBLZXZpbiBXb2xmIDxrd29sZkByZWRo YXQuY29tPgo+Pj4+PiBDQzogTWF4IFJlaXR6IDxtcmVpdHpAcmVkaGF0LmNvbT4KPj4+Pj4gQ0M6 IEdyZWcgS3VyeiA8Z3JvdWdAa2FvZC5vcmc+Cj4+Pj4+IENDOiBTdGVmYW5vIFN0YWJlbGxpbmkg PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4+Pj4+IENDOiBBbnRob255IFBlcmFyZCA8YW50aG9u eS5wZXJhcmRAY2l0cml4LmNvbT4KPj4+Pj4gQ0M6IFBhdWwgRHVycmFudCA8cGF1bEB4ZW4ub3Jn Pgo+Pj4+PiBDQzogU3RlZmFuIEhham5vY3ppIDxzdGVmYW5oYUByZWRoYXQuY29tPgo+Pj4+PiBD QzogIlBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIiA8cGhpbG1kQHJlZGhhdC5jb20+Cj4+Pj4+IEND OiBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPgo+Pj4+PiBDQzogR2VyZCBIb2ZmbWFu biA8a3JheGVsQHJlZGhhdC5jb20+Cj4+Pj4+IENDOiBTdGVmYW4gQmVyZ2VyIDxzdGVmYW5iQGxp bnV4LmlibS5jb20+Cj4+Pj4+IENDOiBNYXJrdXMgQXJtYnJ1c3RlciA8YXJtYnJ1QHJlZGhhdC5j b20+Cj4+Pj4+IENDOiBNaWNoYWVsIFJvdGggPG1kcm90aEBsaW51eC52bmV0LmlibS5jb20+Cj4+ Pj4+IENDOiBxZW11LWJsb2NrQG5vbmdudS5vcmcKPj4+Pj4gQ0M6IHhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZwo+Pj4+Pgo+Pj4+PiAgICBpbmNsdWRlL3FhcGkvZXJyb3IuaCB8IDI2ICsr KysrKysrKysrKysrKysrKysrKysrKysrCj4+Pj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNl cnRpb25zKCspCj4+Pj4+Cj4+Pj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3FhcGkvZXJyb3IuaCBi L2luY2x1ZGUvcWFwaS9lcnJvci5oCj4+Pj4+IGluZGV4IGFkNWI2ZTg5NmQuLmQzNDk4NzE0OGQg MTAwNjQ0Cj4+Pj4+IC0tLSBhL2luY2x1ZGUvcWFwaS9lcnJvci5oCj4+Pj4+ICsrKyBiL2luY2x1 ZGUvcWFwaS9lcnJvci5oCj4+Pj4+IEBAIC0zMDksNiArMzA5LDMyIEBAIHZvaWQgd2Fybl9yZXBv cnRmX2VycihFcnJvciAqZXJyLCBjb25zdCBjaGFyICpmbXQsIC4uLikKPj4+Pj4gICAgdm9pZCBl cnJvcl9yZXBvcnRmX2VycihFcnJvciAqZXJyLCBjb25zdCBjaGFyICpmbXQsIC4uLikKPj4+Pj4g ICAgICAgIEdDQ19GTVRfQVRUUigyLCAzKTsKPj4+Pj4gICAgKy8qCj4+Pj4+ICsgKiBGdW5jdGlv bnMgdG8gY2xlYW4gRXJyb3IgKiplcnJwOiBjYWxsIGNvcnJlc3BvbmRpbmcgRXJyb3IgKmVyciBj bGVhbmluZwo+Pj4+PiArICogZnVuY3Rpb24sIHRoZW4gc2V0IHBvaW50ZXIgdG8gTlVMTC4KPj4+ Pj4gKyAqLwo+Pj4+PiArc3RhdGljIGlubGluZSB2b2lkIGVycm9yX2ZyZWVfZXJycChFcnJvciAq KmVycnApCj4+Pj4+ICt7Cj4+Pj4+ICsgICAgYXNzZXJ0KGVycnAgJiYgKmVycnApOwo+Pj4+PiAr ICAgIGVycm9yX2ZyZWUoKmVycnApOwo+Pj4+PiArICAgICplcnJwID0gTlVMTDsKPj4+Pj4gK30K Pj4+Pj4gKwo+Pj4+PiArc3RhdGljIGlubGluZSB2b2lkIGVycm9yX3JlcG9ydF9lcnJwKEVycm9y ICoqZXJycCkKPj4+Pj4gK3sKPj4+Pj4gKyAgICBhc3NlcnQoZXJycCAmJiAqZXJycCk7Cj4+Pj4+ ICsgICAgZXJyb3JfcmVwb3J0X2VycigqZXJycCk7Cj4+Pj4+ICsgICAgKmVycnAgPSBOVUxMOwo+ Pj4+PiArfQo+Pj4+PiArCj4+Pj4+ICtzdGF0aWMgaW5saW5lIHZvaWQgd2Fybl9yZXBvcnRfZXJy cChFcnJvciAqKmVycnApCj4+Pj4+ICt7Cj4+Pj4+ICsgICAgYXNzZXJ0KGVycnAgJiYgKmVycnAp Owo+Pj4+PiArICAgIHdhcm5fcmVwb3J0X2VycigqZXJycCk7Cj4+Pj4+ICsgICAgKmVycnAgPSBO VUxMOwo+Pj4+PiArfQo+Pj4+PiArCj4+Pj4+ICsKPj4+Pj4gICAgLyoKPj4+Pj4gICAgICogSnVz dCBsaWtlIGVycm9yX3NldGcoKSwgZXhjZXB0IHlvdSBnZXQgdG8gc3BlY2lmeSB0aGUgZXJyb3Ig Y2xhc3MuCj4+Pj4+ICAgICAqIE5vdGU6IHVzZSBvZiBlcnJvciBjbGFzc2VzIG90aGVyIHRoYW4g RVJST1JfQ0xBU1NfR0VORVJJQ19FUlJPUiBpcwo+Pj4+Cj4+Pj4gVGhlc2UgYXBwZWFyIHRvIGJl IHVudXNlZCBhcGFydCBmcm9tIHRoZSBDb2NjaW5lbGxlIHNjcmlwdCBpbiBQQVRDSCAwMy4KPj4+ Pgo+Pj4+IFRoZXkgYXJlIHVzZWQgaW4gdGhlIGZ1bGwgIltSRkMgdjUgMDAwLzEyNl0gZXJyb3I6 IGF1dG8gcHJvcGFnYXRlZAo+Pj4+IGxvY2FsX2VyciIgc2VyaWVzLiAgT3B0aW9uczoKPj4+Pgo+ Pj4+IDEuIFBpY2sgYSBmZXcgbW9yZSBwYXRjaGVzIGludG8gdGhpcyBwYXJ0IEkgc2VyaWVzLCBz byB0aGVzZSBndXlzIGNvbWUKPj4+PiAgICAgIHdpdGggdXNlcnMuCj4+Pgo+Pj4gSXQgbmVlZHMg c29tZSBhZGRpdGlvbmFsIGVmZm9ydCBmb3IgdGhpcyBzZXJpZXMuLiBCdXQgaXQncyBwb3NzaWJs ZS4gU3RpbGwsCj4+PiBJIHRoaW5rIHRoYXQgd2UgYXQgbGVhc3Qgc2hvdWxkIG5vdCBwdWxsIG91 dCBwYXRjaGVzIHdoaWNoIHNob3VsZCBiZSBpbgo+Pj4gZnV0dXJlIHNlcmllcyAoZm9yIGV4YW1w bGUgZnJvbSBwcGMgb3IgYmxvY2svKS4uCj4+Cj4+IFllcywgd2Ugd2FudCB0byBrZWVwIHJlbGF0 ZWQgc3R1ZmYgdG9nZXRoZXIuCj4+Cj4+PiBHcmVwcGluZyB0aHJvdWdoIHY1Ogo+Pj4gICBmb3Ig eCBpbiB7d2Fybl9yZXBvcnRfZXJycCxlcnJvcl9yZXBvcnRfZXJycCxlcnJvcl9mcmVlX2VycnB9 OyBkbyBlY2hvID09ICR4ID09OyBnaXQgZ3JlcCAtbCAkeCB8IGdyZXAgLXYgY29jY2luZWxsZSB8 IGdyZXAgLXYgJ2Vycm9yXC5oJzsgZWNobzsgZG9uZQo+Pj4gPT0gd2Fybl9yZXBvcnRfZXJycCA9 PQo+Pj4gYmxvY2svZmlsZS1wb3NpeC5jCj4+PiBody9wcGMvc3BhcHIuYwo+Pj4gaHcvcHBjL3Nw YXByX2NhcHMuYwo+Pj4gaHcvcHBjL3NwYXByX2lycS5jCj4+PiBody92ZmlvL3BjaS5jCj4+PiBu ZXQvdGFwLmMKPj4+IHFvbS9vYmplY3QuYwo+Pj4KPj4+ID09IGVycm9yX3JlcG9ydF9lcnJwID09 Cj4+PiBody9ibG9jay92aG9zdC11c2VyLWJsay5jCj4+PiB1dGlsL29zbGliLXBvc2l4LmMKPj4+ Cj4+PiA9PSBlcnJvcl9mcmVlX2VycnAgPT0KPj4+IGJsb2NrLmMKPj4+IGJsb2NrL3FhcGkuYwo+ Pj4gYmxvY2svc2hlZXBkb2cuYwo+Pj4gYmxvY2svc25hcHNob3QuYwo+Pj4gYmxvY2tkZXYuYwo+ Pj4gY2hhcmRldi9jaGFyLXNvY2tldC5jCj4+PiBody9hdWRpby9pbnRlbC1oZGEuYwo+Pj4gaHcv Y29yZS9xZGV2LXByb3BlcnRpZXMuYwo+Pj4gaHcvcGNpLWJyaWRnZS9wY2lfYnJpZGdlX2Rldi5j Cj4+PiBody9wY2ktYnJpZGdlL3BjaWVfcGNpX2JyaWRnZS5jCj4+PiBody9zY3NpL21lZ2FzYXMu Ywo+Pj4gaHcvc2NzaS9tcHRzYXMuYwo+Pj4gaHcvdXNiL2hjZC14aGNpLmMKPj4+IGlvL25ldC1s aXN0ZW5lci5jCj4+PiBtaWdyYXRpb24vY29sby5jCj4+PiBxZ2EvY29tbWFuZHMtcG9zaXguYwo+ Pj4gcWdhL2NvbW1hbmRzLXdpbjMyLmMKPj4+IHV0aWwvcWVtdS1zb2NrZXRzLmMKPj4+Cj4+PiBX aGF0IGRvIHlvdSB3YW50IHRvIGFkZD8KPj4KPj4gUEFUQ0ggdjUgMDMyIHVzZXMgYm90aCBlcnJv cl9yZXBvcnRfZXJycCgpIGFuZCBlcnJvcl9mcmVlX2VycnAoKS4KPj4gQWRkaW5nIHdhcm5fcmVw b3J0X2VycnAoKSB3aXRob3V0IGEgdXNlciBpcyBva2F5IHdpdGggbWUuICBXaGF0IGRvIHlvdQo+ PiB0aGluaz8KPj4KPj4gSWYgdGhlcmUgYXJlIHBhdGNoZXMgeW91IGNvbnNpZGVyIHJlbGF0ZWQg dG8gMDMyLCBmZWVsIGZyZWUgdG8gdGhyb3cKPj4gdGhlbSBpbi4KPgo+IDAzMiBpcyBxZ2EvY29t bWFuZHMtd2luMzIuYyBhbmQgdXRpbC9vc2xpYi1wb3NpeC5jCj4KPiBTZWVtcyB0aGF0IHRoZXkg YXJlIHdyb25nbHkgZ3JvdXBlZCBpbnRvIG9uZSBwYXRjaC4KPgo+IHFnYS9jb21tYW5kcy13aW4z Mi5jIG1hdGNoZXMgcWdhLyAoTWljaGFlbCBSb3RoKQo+IGFuZCAgdXRpbC9vc2xpYi1wb3NpeC5j IG1hdGNoZXMgUE9TSVggKFBhb2xvIEJvbnppbmkpCj4KPiBTbywgaXQgc2hvdWxkIGJlIHR3byBz ZXBhcmF0ZSBwYXRjaGVzIGFueXdheS4KPgo+IEZvciBbMS5dIEkgb25seSBhZnJhaWQgdGhhdCB3 ZSdsbCBoYXZlIHRvIHdhaXQgZm9yIG1haW50YWluZXJzLCB3aG8gd2VyZQo+IG5vdCBpbnRlcmVz dGVkIGluIHByZXZpb3VzIGl0ZXJhdGlvbnMsIHRvIHJldmlldyB0aGVzZSBuZXcgcGF0Y2hlcy4u CgpXZSB3b24ndC4KCldlIHNob3VsZCBhbmQgd2Ugd2lsbCBnaXZlIGV2ZXJ5IG1haW50YWluZXIg YSBjaGFuY2UgdG8gcmV2aWV3IHRoZXNlCnBhdGNoZXMsIGV2ZW4gdGhvdWdoIHRoZSBjaGFuZ2Vz IGFyZSBtZWNoYW5pY2FsLiAgTWFpbnRhaW5lcnMgYXJlIGZyZWUKdG8gZGVjbGluZSBvciBpZ25v cmUgdGhpcyBvZmZlci4gIEkgd2lsbCBmZWVsIGZyZWUgdG8gaW50ZXJwcmV0IHRoYXQgYXMKImdv IGFoZWFkIGFuZCBtZXJnZSB0aGlzIHRocm91Z2ggeW91ciB0cmVlIi4KCkluIGZhY3QsIEkgZnVs bHkgZXhwZWN0IHRoZSBidWxrIG9mIHRoZSBjaGFuZ2VzIHRvIGdvIHRocm91Z2ggbXkgdHJlZS4K Q2hhc2luZyB1bXB0ZWVuIG1haW50YWluZXJzIGZvciBlYWNoIG9uZSB0byBtZXJnZSBhIHRyaXZp YWwgcGFydCBvZiB0aGlzCm1hc3NpdmUgdHJlZS13aWRlIGNoYW5nZSB3b3VsZCB0YWtlIGFnZXMg YW5kIGFjY29tcGxpc2ggbm90aGluZy4KClsuLi5dCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2BBC35669 for ; Sat, 22 Feb 2020 08:24:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 579CF20707 for ; Sat, 22 Feb 2020 08:24:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ibknjp5y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 579CF20707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5Q5k-0000Vn-K1 for qemu-devel@archiver.kernel.org; Sat, 22 Feb 2020 03:24:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33161) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5Q58-0008Qs-Cb for qemu-devel@nongnu.org; Sat, 22 Feb 2020 03:24:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5Q56-00050d-Hp for qemu-devel@nongnu.org; Sat, 22 Feb 2020 03:24:14 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:60354 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j5Q56-00050E-ED for qemu-devel@nongnu.org; Sat, 22 Feb 2020 03:24:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582359851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T45vrP9XIhTb9vS7RjFPPl1JpkYIOutb0fUu3RFTTrw=; b=Ibknjp5yCD9t8t8M1bLmQSxRwMfGL24Jt/+owGZ9h5EqoQ24qkat4Tr6Rwln85defxydlu ffKxfpWGYsQ6H0UTCWxUjW5DqwfcGv5Khgun91oUtol/h82gp9FTvZvjEHzEvN0UWOJONJ IftnMcfhyMG6bv0kjqgqkg2xesXmQ40= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-52XP2uA5M1qKR3W2VghM7A-1; Sat, 22 Feb 2020 03:24:09 -0500 X-MC-Unique: 52XP2uA5M1qKR3W2VghM7A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4A4C189F760; Sat, 22 Feb 2020 08:24:07 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F176391; Sat, 22 Feb 2020 08:24:01 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A616511386A6; Sat, 22 Feb 2020 09:23:59 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs References: <20200131130118.1716-1-vsementsov@virtuozzo.com> <20200131130118.1716-2-vsementsov@virtuozzo.com> <87d0a88k6d.fsf@dusky.pond.sub.org> <7856fcbb-8c01-aba3-a11b-63058c117362@virtuozzo.com> <875zfz6gsh.fsf@dusky.pond.sub.org> <064ca8e9-458e-c780-92a0-05f40cf0975b@virtuozzo.com> Date: Sat, 22 Feb 2020 09:23:59 +0100 In-Reply-To: <064ca8e9-458e-c780-92a0-05f40cf0975b@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Fri, 21 Feb 2020 20:31:55 +0300") Message-ID: <87sgj31140.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, Paul Durrant , qemu-devel@nongnu.org, Laszlo Ersek , Markus Armbruster , Michael Roth , Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vladimir Sementsov-Ogievskiy writes: > 21.02.2020 19:34, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 21.02.2020 10:38, Markus Armbruster wrote: >>>> Vladimir Sementsov-Ogievskiy writes: >>>> >>>>> Add functions to clean Error **errp: call corresponding Error *err >>>>> cleaning function an set pointer to NULL. >>>>> >>>>> New functions: >>>>> error_free_errp >>>>> error_report_errp >>>>> warn_report_errp >>>>> >>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>>>> Reviewed-by: Greg Kurz >>>>> Reviewed-by: Eric Blake >>>>> --- >>>>> >>>>> CC: Eric Blake >>>>> CC: Kevin Wolf >>>>> CC: Max Reitz >>>>> CC: Greg Kurz >>>>> CC: Stefano Stabellini >>>>> CC: Anthony Perard >>>>> CC: Paul Durrant >>>>> CC: Stefan Hajnoczi >>>>> CC: "Philippe Mathieu-Daud=C3=A9" >>>>> CC: Laszlo Ersek >>>>> CC: Gerd Hoffmann >>>>> CC: Stefan Berger >>>>> CC: Markus Armbruster >>>>> CC: Michael Roth >>>>> CC: qemu-block@nongnu.org >>>>> CC: xen-devel@lists.xenproject.org >>>>> >>>>> include/qapi/error.h | 26 ++++++++++++++++++++++++++ >>>>> 1 file changed, 26 insertions(+) >>>>> >>>>> diff --git a/include/qapi/error.h b/include/qapi/error.h >>>>> index ad5b6e896d..d34987148d 100644 >>>>> --- a/include/qapi/error.h >>>>> +++ b/include/qapi/error.h >>>>> @@ -309,6 +309,32 @@ void warn_reportf_err(Error *err, const char *fm= t, ...) >>>>> void error_reportf_err(Error *err, const char *fmt, ...) >>>>> GCC_FMT_ATTR(2, 3); >>>>> +/* >>>>> + * Functions to clean Error **errp: call corresponding Error *err cl= eaning >>>>> + * function, then set pointer to NULL. >>>>> + */ >>>>> +static inline void error_free_errp(Error **errp) >>>>> +{ >>>>> + assert(errp && *errp); >>>>> + error_free(*errp); >>>>> + *errp =3D NULL; >>>>> +} >>>>> + >>>>> +static inline void error_report_errp(Error **errp) >>>>> +{ >>>>> + assert(errp && *errp); >>>>> + error_report_err(*errp); >>>>> + *errp =3D NULL; >>>>> +} >>>>> + >>>>> +static inline void warn_report_errp(Error **errp) >>>>> +{ >>>>> + assert(errp && *errp); >>>>> + warn_report_err(*errp); >>>>> + *errp =3D NULL; >>>>> +} >>>>> + >>>>> + >>>>> /* >>>>> * Just like error_setg(), except you get to specify the error cla= ss. >>>>> * Note: use of error classes other than ERROR_CLASS_GENERIC_ERROR= is >>>> >>>> These appear to be unused apart from the Coccinelle script in PATCH 03= . >>>> >>>> They are used in the full "[RFC v5 000/126] error: auto propagated >>>> local_err" series. Options: >>>> >>>> 1. Pick a few more patches into this part I series, so these guys come >>>> with users. >>> >>> It needs some additional effort for this series.. But it's possible. St= ill, >>> I think that we at least should not pull out patches which should be in >>> future series (for example from ppc or block/).. >> >> Yes, we want to keep related stuff together. >> >>> Grepping through v5: >>> for x in {warn_report_errp,error_report_errp,error_free_errp}; do ech= o =3D=3D $x =3D=3D; git grep -l $x | grep -v coccinelle | grep -v 'error\.h= '; echo; done >>> =3D=3D warn_report_errp =3D=3D >>> block/file-posix.c >>> hw/ppc/spapr.c >>> hw/ppc/spapr_caps.c >>> hw/ppc/spapr_irq.c >>> hw/vfio/pci.c >>> net/tap.c >>> qom/object.c >>> >>> =3D=3D error_report_errp =3D=3D >>> hw/block/vhost-user-blk.c >>> util/oslib-posix.c >>> >>> =3D=3D error_free_errp =3D=3D >>> block.c >>> block/qapi.c >>> block/sheepdog.c >>> block/snapshot.c >>> blockdev.c >>> chardev/char-socket.c >>> hw/audio/intel-hda.c >>> hw/core/qdev-properties.c >>> hw/pci-bridge/pci_bridge_dev.c >>> hw/pci-bridge/pcie_pci_bridge.c >>> hw/scsi/megasas.c >>> hw/scsi/mptsas.c >>> hw/usb/hcd-xhci.c >>> io/net-listener.c >>> migration/colo.c >>> qga/commands-posix.c >>> qga/commands-win32.c >>> util/qemu-sockets.c >>> >>> What do you want to add? >> >> PATCH v5 032 uses both error_report_errp() and error_free_errp(). >> Adding warn_report_errp() without a user is okay with me. What do you >> think? >> >> If there are patches you consider related to 032, feel free to throw >> them in. > > 032 is qga/commands-win32.c and util/oslib-posix.c > > Seems that they are wrongly grouped into one patch. > > qga/commands-win32.c matches qga/ (Michael Roth) > and util/oslib-posix.c matches POSIX (Paolo Bonzini) > > So, it should be two separate patches anyway. > > For [1.] I only afraid that we'll have to wait for maintainers, who were > not interested in previous iterations, to review these new patches.. We won't. We should and we will give every maintainer a chance to review these patches, even though the changes are mechanical. Maintainers are free to decline or ignore this offer. I will feel free to interpret that as "go ahead and merge this through your tree". In fact, I fully expect the bulk of the changes to go through my tree. Chasing umpteen maintainers for each one to merge a trivial part of this massive tree-wide change would take ages and accomplish nothing. [...]